Summary: | Histogram total allocated bytes in the arena in addition to the render tree size | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ojan Vafai <ojan> | ||||||||
Component: | New Bugs | Assignee: | Ojan Vafai <ojan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | eric, hyatt, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 87967 | ||||||||||
Attachments: |
|
Description
Ojan Vafai
2012-05-03 13:06:26 PDT
Created attachment 140078 [details]
Patch
I'm a bit torn on making the bytesAllocated an out-param instead of just adding a new method to Page. It avoids some code duplication. In theory it's also faster because we only walk the frame-tree once, but I doubt that matters in practice. Happy to change it if you think a separate method would be cleaner. Comment on attachment 140078 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140078&action=review > Source/WebCore/page/Page.h:121 > - size_t renderTreeSize() const; > + size_t renderTreeSize(size_t& totalRenderArenaAllocatedBytes) const; You could alternatively return a simple struct? (In reply to comment #3) > (From update of attachment 140078 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=140078&action=review > > > Source/WebCore/page/Page.h:121 > > - size_t renderTreeSize() const; > > + size_t renderTreeSize(size_t& totalRenderArenaAllocatedBytes) const; > > You could alternatively return a simple struct? That's probably cleaner. Will fix. Comment on attachment 140078 [details] Patch Attachment 140078 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12611316 Created attachment 140109 [details]
Patch
Comment on attachment 140109 [details] Patch Attachment 140109 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12620250 Comment on attachment 140109 [details] Patch Attachment 140109 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12612399 Comment on attachment 140109 [details] Patch Attachment 140109 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12514238 Created attachment 140118 [details]
Patch
OK. All the bots are happily compiling now. Eric, squeak! Comment on attachment 140118 [details]
Patch
Works for me.
Comment on attachment 140118 [details] Patch Clearing flags on attachment: 140118 Committed r116058: <http://trac.webkit.org/changeset/116058> All reviewed patches have been landed. Closing bug. |