Bug 85526

Summary:

Add test that makes sure wrappers are setup using the correct window scope

Product:

WebKit

Reporter:

Erik Arvidsson <arv>

Component:

Tools / Tests

Assignee:

Erik Arvidsson <arv>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, darin, dglazkov, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ec2-cr-linux-01	none
Patch	none
Patch for landing	none

Erik Arvidsson

Reported 2012-05-03 11:45:38 PDT

Add test that makes sure wrappers are setup using the correct window scope

Attachments
Patch (5.20 KB, patch) 2012-05-03 11:47 PDT, Erik Arvidsson	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-01 (5.67 MB, application/zip) 2012-05-03 12:42 PDT, WebKit Review Bot	no flags	Details
Patch (5.20 KB, patch) 2012-05-03 13:01 PDT, Erik Arvidsson	no flags	Details Formatted Diff Diff
Patch for landing (5.42 KB, patch) 2012-05-10 09:10 PDT, Erik Arvidsson	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Erik Arvidsson

Comment 1 2012-05-03 11:47:12 PDT

Created attachment 140058 [details] Patch

Erik Arvidsson

Comment 2 2012-05-03 11:54:58 PDT

Any other properties you would like this to cover from the removed prototype-inheritance.html?

WebKit Review Bot

Comment 3 2012-05-03 12:42:16 PDT

Comment on attachment 140058 [details] Patch Attachment 140058 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12621139 New failing tests: fast/dom/wrapper-scope.html

WebKit Review Bot

Comment 4 2012-05-03 12:42:22 PDT

Created attachment 140069 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Erik Arvidsson

Comment 5 2012-05-03 13:01:47 PDT

Created attachment 140072 [details] Patch

Erik Arvidsson

Comment 6 2012-05-03 13:02:15 PDT

Fixed the typo in test_expectations.txt

Erik Arvidsson

Comment 7 2012-05-04 11:17:38 PDT

Darin, do you have any other concerns. Any other properties you feel strongly needs to be tested?

WebKit Review Bot

Comment 8 2012-05-08 12:13:01 PDT

Comment on attachment 140072 [details] Patch Rejecting attachment 140072 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: eeded at 1 with fuzz 3. patching file LayoutTests/fast/dom/wrapper-scope-expected.txt patching file LayoutTests/fast/dom/wrapper-scope.html patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #1 FAILED at 3870. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Ojan Vafai']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12643731

Erik Arvidsson

Comment 9 2012-05-10 09:10:35 PDT

Created attachment 141179 [details] Patch for landing

WebKit Review Bot

Comment 10 2012-05-10 09:47:01 PDT

Comment on attachment 141179 [details] Patch for landing Clearing flags on attachment: 141179 Committed r116655: <http://trac.webkit.org/changeset/116655>

WebKit Review Bot

Comment 11 2012-05-10 09:47:17 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.