| Summary: | Add test that makes sure wrappers are setup using the correct window scope | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Erik Arvidsson <arv> | ||||||||||
| Component: | Tools / Tests | Assignee: | Erik Arvidsson <arv> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | ap, darin, dglazkov, ojan, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Erik Arvidsson
2012-05-03 11:45:38 PDT
Created attachment 140058 [details]
Patch
Any other properties you would like this to cover from the removed prototype-inheritance.html? Comment on attachment 140058 [details] Patch Attachment 140058 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12621139 New failing tests: fast/dom/wrapper-scope.html Created attachment 140069 [details]
Archive of layout-test-results from ec2-cr-linux-01
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 140072 [details]
Patch
Fixed the typo in test_expectations.txt Darin, do you have any other concerns. Any other properties you feel strongly needs to be tested? Comment on attachment 140072 [details] Patch Rejecting attachment 140072 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: eeded at 1 with fuzz 3. patching file LayoutTests/fast/dom/wrapper-scope-expected.txt patching file LayoutTests/fast/dom/wrapper-scope.html patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #1 FAILED at 3870. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Ojan Vafai']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12643731 Created attachment 141179 [details]
Patch for landing
Comment on attachment 141179 [details] Patch for landing Clearing flags on attachment: 141179 Committed r116655: <http://trac.webkit.org/changeset/116655> All reviewed patches have been landed. Closing bug. |