Bug 85526

Summary: Add test that makes sure wrappers are setup using the correct window scope
Product: WebKit Reporter: Erik Arvidsson <arv>
Component: Tools / TestsAssignee: Erik Arvidsson <arv>
Severity: Normal CC: ap, darin, dglazkov, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Archive of layout-test-results from ec2-cr-linux-01
Patch for landing none

Description Erik Arvidsson 2012-05-03 11:45:38 PDT
Add test that makes sure wrappers are setup using the correct window scope
Comment 1 Erik Arvidsson 2012-05-03 11:47:12 PDT
Created attachment 140058 [details]
Comment 2 Erik Arvidsson 2012-05-03 11:54:58 PDT
Any other properties you would like this to cover from the removed prototype-inheritance.html?
Comment 3 WebKit Review Bot 2012-05-03 12:42:16 PDT
Comment on attachment 140058 [details]

Attachment 140058 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12621139

New failing tests:
Comment 4 WebKit Review Bot 2012-05-03 12:42:22 PDT
Created attachment 140069 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 5 Erik Arvidsson 2012-05-03 13:01:47 PDT
Created attachment 140072 [details]
Comment 6 Erik Arvidsson 2012-05-03 13:02:15 PDT
Fixed the typo in test_expectations.txt
Comment 7 Erik Arvidsson 2012-05-04 11:17:38 PDT
Darin, do you have any other concerns. Any other properties you feel strongly needs to be tested?
Comment 8 WebKit Review Bot 2012-05-08 12:13:01 PDT
Comment on attachment 140072 [details]

Rejecting attachment 140072 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
eeded at 1 with fuzz 3.
patching file LayoutTests/fast/dom/wrapper-scope-expected.txt
patching file LayoutTests/fast/dom/wrapper-scope.html
patching file LayoutTests/platform/chromium/test_expectations.txt
Hunk #1 FAILED at 3870.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Ojan Vafai']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12643731
Comment 9 Erik Arvidsson 2012-05-10 09:10:35 PDT
Created attachment 141179 [details]
Patch for landing
Comment 10 WebKit Review Bot 2012-05-10 09:47:01 PDT
Comment on attachment 141179 [details]
Patch for landing

Clearing flags on attachment: 141179

Committed r116655: <http://trac.webkit.org/changeset/116655>
Comment 11 WebKit Review Bot 2012-05-10 09:47:17 PDT
All reviewed patches have been landed.  Closing bug.