Bug 85477

Summary: Web Inspector: createRawLocationByURL is too slow if a big number of evals happen.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch yurys: review+

Ilya Tikhonovsky
Reported 2012-05-03 05:06:29 PDT
It iterates through all the _scripts even they have no url. We can keep a separate map of scripts with url.
Attachments
Patch (10.24 KB, patch)
2012-05-03 05:36 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Patch (10.87 KB, patch)
2012-05-04 01:26 PDT, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-05-03 05:36:17 PDT
Created attachment 139990 [details] Patch
Yury Semikhatsky
Comment 2 2012-05-03 05:46:23 PDT
Comment on attachment 139990 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139990&action=review > Source/WebCore/inspector/front-end/DebuggerModel.js:226 > + _resetScriptsMap: function() _resetScriptsMap -> _resetScriptMaps ? > Source/WebCore/inspector/front-end/DebuggerModel.js:338 > + this._scriptsWithSourceURL[scriptId] = script; Let's introduce a multimap from source URL to scripts instead to avoid the linear pass.
Ilya Tikhonovsky
Comment 3 2012-05-04 01:26:11 PDT
Created attachment 140179 [details] Patch
Yury Semikhatsky
Comment 4 2012-05-04 01:43:51 PDT
Comment on attachment 140179 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140179&action=review > Source/WebCore/inspector/front-end/DebuggerModel.js:337 > + scripts = {}; You never get a script by id from this map, why not use an array of scripts instead?
Pavel Feldman
Comment 5 2012-05-04 01:47:14 PDT
Comment on attachment 140179 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140179&action=review > Source/WebCore/inspector/front-end/DebuggerModel.js:223 > + _resetScriptsMaps: function() _reset ?
Ilya Tikhonovsky
Comment 6 2012-05-04 02:09:25 PDT
Committed r116077: <http://trac.webkit.org/changeset/116077>
Note You need to log in before you can comment on or make changes to this bug.