Bug 85467

Summary: Linker warnings due to duplicate symbols for SimplifyMarkupCommand.cpp on Windows
Product: WebKit Reporter: Vivek Galatage <vivekgalatage>
Component: HTML EditingAssignee: Vivek Galatage <vivekgalatage>
Status: RESOLVED FIXED    
Severity: Normal CC: rniwa, vivekgalatage, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Vivek Galatage
Reported 2012-05-03 01:59:53 PDT
While building Debug/Debug_All/Release builds for windows while linking WebCore.lib following warnings are issued: Performing Pre-Link Event... Creating library... EditingAllInOne.obj : warning LNK4006: "private: __thiscall WebCore::SimplifyMarkupCommand::SimplifyMarkupCommand(class WebCore::Document *,class WebCore::Node *,class WebCore::Node *)" (??0SimplifyMarkupCommand@WebCore@@AAE@PAVDocument@1@PAVNode@1@1@Z) already defined in SimplifyMarkupCommand.obj; second definition ignored EditingAllInOne.obj : warning LNK4006: "private: virtual void __thiscall WebCore::SimplifyMarkupCommand::doApply(void)" (?doApply@SimplifyMarkupCommand@WebCore@@EAEXXZ) already defined in SimplifyMarkupCommand.obj; second definition ignored Performing Post-Build Event...
Attachments
Patch (1.82 KB, patch)
2012-05-03 02:14 PDT, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
Patch (1.83 KB, patch)
2012-05-03 02:37 PDT, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vivek Galatage
Comment 1 2012-05-03 02:01:27 PDT
The file has been included multiple times both in EditingAllInOne.cpp as well as its not excluded from build in the WebCore.vcproj Hence while linking this error is thrown. The file has to be excluded as this is included in AllInOne.cpp. Patch to follow.
Vivek Galatage
Comment 2 2012-05-03 02:14:59 PDT
Created attachment 139974 [details] Patch
Ryosuke Niwa
Comment 3 2012-05-03 02:24:54 PDT
Comment on attachment 139974 [details] Patch Looks sane. Please update the bug title.
Vivek Galatage
Comment 4 2012-05-03 02:37:58 PDT
Created attachment 139976 [details] Patch
WebKit Review Bot
Comment 5 2012-05-03 03:38:01 PDT
Comment on attachment 139976 [details] Patch Clearing flags on attachment: 139976 Committed r115956: <http://trac.webkit.org/changeset/115956>
WebKit Review Bot
Comment 6 2012-05-03 03:38:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.