Bug 85438

Summary: Flash of white when exiting full screen HTML5 video
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar, PlatformOnly
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch sam: review+

Jer Noble
Reported 2012-05-02 17:28:51 PDT
Flash of white when exiting full screen HTML5 video
Attachments
Patch (2.95 KB, patch)
2012-05-02 17:31 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (3.44 KB, patch)
2012-05-04 16:24 PDT, Jer Noble 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2012-05-02 17:31:51 PDT
Created attachment 139923 [details] Patch
Jer Noble
Comment 2 2012-05-02 17:32:02 PDT
<rdar://problem/11364210>
Maciej Stachowiak
Comment 3 2012-05-02 23:30:05 PDT
Comment on attachment 139923 [details] Patch r=me Is it possible to make a test for this?
Jer Noble
Comment 4 2012-05-03 09:10:54 PDT
We could make a manual test. But there's no way to write a DRT or WKRT automated test for this.
Jer Noble
Comment 5 2012-05-04 13:55:42 PDT
After making a test case for this patch, i see that the flash is still occurring. (though less often, & with a shorter flash.) Pulling this patch and investigating further.
Jer Noble
Comment 6 2012-05-04 14:17:25 PDT
This looks like a problem with the TiledCoreAnimationDrawingAreaProxy. When attempting to sync up drawing between the UIProcess and the WebProcess, this patch calls WebPageProxy::forceRepaint(), which in turn calls m_drawingArea->waitForBackingStoreUpdateOnNextPaint(); The drawing area in question is a TiledCoreAnimationDrawingAreaProxy, and it doesn't implement waitForBackingStoreUpdateOnNextPaint(), it gets effectively ignored.
Jer Noble
Comment 7 2012-05-04 14:23:12 PDT
Indeed, if I disable tiled drawing and full page acceleration, the flashing problem disappears.
Jer Noble
Comment 8 2012-05-04 16:24:55 PDT
Created attachment 140359 [details] Patch
Jer Noble
Comment 9 2012-05-04 16:30:24 PDT
Committed r116188: <http://trac.webkit.org/changeset/116188>
Note You need to log in before you can comment on or make changes to this bug.