Bug 85430

Summary: Remove window-properties.html and other iterate over all possible properties tests
Product: WebKit Reporter: Erik Arvidsson <arv>
Component: Tools / TestsAssignee: Erik Arvidsson <arv>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, darin, eric, levin, mjs, ojan, rakuco, rniwa, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Erik Arvidsson
Reported 2012-05-02 16:21:39 PDT
Remove window-properties.html and other iterate over all possible properties tests
Attachments
Patch (1.79 MB, patch)
2012-05-02 16:24 PDT, Erik Arvidsson 		no flags
DetailsFormatted DiffDiff
Patch (1.79 MB, patch)
2012-05-02 17:12 PDT, Erik Arvidsson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Erik Arvidsson
Comment 1 2012-05-02 16:24:20 PDT
Created attachment 139907 [details] Patch
Erik Arvidsson
Comment 2 2012-05-02 16:26:46 PDT
Ojan, I couldn't find the svg test you were talking about
Raphael Kubo da Costa (:rakuco)
Comment 3 2012-05-02 16:40:23 PDT
Can you please remove the prototype-inheritance*.html tests from EFL's Skipped file as well?
Erik Arvidsson
Comment 4 2012-05-02 17:12:32 PDT
Created attachment 139921 [details] Patch
Erik Arvidsson
Comment 5 2012-05-02 17:12:56 PDT
(In reply to comment #3) > Can you please remove the prototype-inheritance*.html tests from EFL's Skipped file as well? Done.
Alexey Proskuryakov
Comment 6 2012-05-02 17:25:50 PDT
I'm in favor of this change.
Eric Seidel (no email)
Comment 7 2012-05-02 17:33:37 PDT
Comment on attachment 139921 [details] Patch We lose some coverage here, definitely. But it's OK. These tests have caused more harm than good.
WebKit Review Bot
Comment 8 2012-05-02 18:48:00 PDT
Comment on attachment 139921 [details] Patch Clearing flags on attachment: 139921 Committed r115927: <http://trac.webkit.org/changeset/115927>
WebKit Review Bot
Comment 9 2012-05-02 18:48:09 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 10 2012-05-02 22:28:08 PDT
I’m OK with removing window-properties.html. It just lists everything and doesn’t really test anything beyond what we can iterate. But I am not in favor of deleting the prototype inheritance tests! We can change them so their output doesn’t dump out the names of all the classes, but we still want to do the test. The prototype inheritance test doesn’t just dump everything out. Please add the prototype inheritance test back and instead revise them so their output does not list everything!
Note You need to log in before you can comment on or make changes to this bug.