Summary: | [Chromium] Call isLinkVisited directly | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Pilgrim (Google) <pilgrim> | ||||||||||
Component: | WebKit Misc. | Assignee: | Mark Pilgrim (Google) <pilgrim> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, fishd, gustavo, haraken, philn, rakuco, webkit.review.bot, xan.lopez | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 82948 | ||||||||||||
Attachments: |
|
Description
Mark Pilgrim (Google)
2012-05-02 13:16:38 PDT
I'm pretty sure that we need to maintain the Chromium specific code paths. The reason for this is that we use a shared memory buffer on the Chromium-side to implement these functions. Created attachment 140949 [details]
Patch
OK, new VisitedLinkSupport.cpp/h and VisitedLinkSupportChromium.cpp to house isLinkVisited function inside WebCore. Same pattern as, for example, bug 84376. Comment on attachment 140949 [details] Patch Attachment 140949 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12649712 Comment on attachment 140949 [details] Patch Attachment 140949 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12654624 Comment on attachment 140949 [details] Patch Attachment 140949 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12651652 Comment on attachment 140949 [details] Patch Attachment 140949 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/12664026 Comment on attachment 140949 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140949&action=review Looks like you've got some compile troubles. > Source/WebCore/page/PageGroup.cpp:179 > - return PlatformSupport::isLinkVisited(visitedLinkHash); > + return VisitedLinkSupport::isLinkVisited(visitedLinkHash); I wonder if we should move this into the client. This seems more like something the ChromeClient should worry about... If we are going to keep this as a static, we should use a better name than VisitedLinkSupport though. Perhaps VistedLinks? Created attachment 141238 [details]
Patch
Comment on attachment 141238 [details]
Patch
Fixed missing include, should fix compile problems. Also renamed VisitedLinkSupport to VisitedLinks.
Comment on attachment 141238 [details]
Patch
Did the entry in the header already move?
Created attachment 141541 [details]
Patch
Comment on attachment 141541 [details]
Patch
Repatch for ToT.
Comment on attachment 141541 [details] Patch Attachment 141541 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12668610 Comment on attachment 141541 [details] Patch Attachment 141541 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/12677371 Comment on attachment 141541 [details] Patch Attachment 141541 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12671559 Comment on attachment 141541 [details] Patch Attachment 141541 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12666693 Created attachment 141545 [details]
Patch
Comment on attachment 141545 [details]
Patch
Well that went badly. Let's try again.
Comment on attachment 141545 [details]
Patch
That looks a lot greener. :)
Comment on attachment 141545 [details] Patch Clearing flags on attachment: 141545 Committed r116840: <http://trac.webkit.org/changeset/116840> All reviewed patches have been landed. Closing bug. |