Bug 85407

Summary: webkitpy: Remove direct sys.platform usage in the PNG checker.
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: Tools / TestsAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, levin, ojan, rniwa, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 81560    
Attachments:
Description Flags
Patch tony: review+

Raphael Kubo da Costa (:rakuco)
Reported 2012-05-02 12:54:45 PDT
webkitpy: Remove direct sys.platform usage in the PNG checker.
Attachments
Patch (6.12 KB, patch)
2012-05-02 12:57 PDT, Raphael Kubo da Costa (:rakuco) 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2012-05-02 12:57:02 PDT
Created attachment 139862 [details] Patch
Tony Chang
Comment 2 2012-05-02 13:24:42 PDT
Comment on attachment 139862 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139862&action=review > Tools/Scripts/webkitpy/style/checkers/png.py:99 > + if not self._platform.is_win(): > config_file_path = self._fs.join(self._fs.expanduser("~"), ".subversion/config") > - elif self._platform.startswith('win') or self._platform.startswith('cygwin'): > + else: > config_file_path = self._fs.join(os.environ['APPDATA'], "Subversion\config") Nit: I would put the platform.is_win case first, but this is also fine.
Raphael Kubo da Costa (:rakuco)
Comment 3 2012-05-02 13:37:29 PDT
Committed r115880: <http://trac.webkit.org/changeset/115880>
Note You need to log in before you can comment on or make changes to this bug.