Bug 85401
| Summary: | media/video-colorspace-yuv420.html and media/video-colorspace-yuv422.html fail on Mac | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> |
| Component: | Media | Assignee: | Eric Carlson <eric.carlson> |
| Status: | NEW | ||
| Severity: | Normal | CC: | aestes, ahmad.saleem792, eric.carlson, fpizlo, jberlin, jer.noble |
| Priority: | P2 | Keywords: | LayoutTestFailure, MakingBotsRed |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | All | ||
Filip Pizlo
That should be fixed. For now I'm skipping them
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Filip Pizlo
Changed expectations in http://trac.webkit.org/changeset/115863
Eric Carlson
The MPEG-4 files used in these tests are compressed with H.264 using profile 122, which is "High 4:2:2" profile (the data is not really YUV). AVFoundation does not currently support this profile, so they should be rejected and tests *should* fail but they do not. This is being tracked by rdar://11363908.
These show up as broken on the bots because the committed results show FAIL, but AVFoundation doesn't return an error so we think the file was opened correctly.
These tests don't actually test WebKit, they tests the Chrome media engine, so they should probably not be layout tests at all. I will talk to the engineers about removing them.
Jessie Berlin
These tests have started passing on Lion:
http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r127191%20(2391)/results.html
I am not sure exactly when they started passing, because the revision they started passing when expected to be failing at was when Dirk Pranke made the mac-lion TestExpectations file start working (http://trac.webkit.org/changeset/127190), but I am going to remove the failing expectations.
Jessie Berlin
(In reply to comment #2)
> The MPEG-4 files used in these tests are compressed with H.264 using profile 122, which is "High 4:2:2" profile (the data is not really YUV). AVFoundation does not currently support this profile, so they should be rejected and tests *should* fail but they do not. This is being tracked by rdar://11363908.
>
> These show up as broken on the bots because the committed results show FAIL, but AVFoundation doesn't return an error so we think the file was opened correctly.
>
> These tests don't actually test WebKit, they tests the Chrome media engine, so they should probably not be layout tests at all. I will talk to the engineers about removing them.
Removed in http://trac.webkit.org/changeset/127216
Ahmad Saleem
We have them as [WONTFIX]:
https://searchfox.org/wubkat/source/LayoutTests/platform/mac/TestExpectations#685
# Mac doesn't support YUV 420/422 colorspace
media/video-colorspace-yuv420.html [ WontFix ]
media/video-colorspace-yuv422.html [ WontFix ]
Do we need to do anything here?