Bug 85375 – [EFL] Fix scroll issue in single backing store for custom scrollbars

• Component: WebKit EFL
• Status: RESOLVED DUPLICATE

[Mariusz Grzegorczyk]

Created attachment 139815 [details]
Screenshot of EWebLauncher with broken layout(http://support.google.com/bin/static.py?hl=en&page=top_products.cs&rd=1)

Layout is broken after scrolling on EWebLauncher when ::-webkit-scrollbar css style is used with single backing store.

[Mariusz Grzegorczyk]

Created attachment 139816 [details]
Fix scroll issue in single backing store when ::-webkit-scrollbar css style is used.

[Ryuan Choi]

*** This bug has been marked as a duplicate of bug 77325 ***

[Eric Seidel (no email)]

Comment on attachment 139816 [details]
Fix scroll issue in single backing store when ::-webkit-scrollbar css style is used.

Cleared review? from attachment 139816 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).

[Ryuan Choi]

I checked and found remaining issue although Bug 77325 applied.
After resized and scrolled, some afterimage is remained on scrollbar area.
So, I think that this is still valid.

Sorry about my confusion.

[Chris Dumez]

Comment on attachment 139816 [details]
Fix scroll issue in single backing store when ::-webkit-scrollbar css style is used.

View in context: https://bugs.webkit.org/attachment.cgi?id=139816&action=review

> Source/WebKit/efl/ewk/ewk_private.h:245
> +bool ewk_frame_scrollbars_size_get(const Evas_Object* ewkFrame, int* width, int* height);

This needs to be moved to ewk_frame_private.h now.

> Source/WebKit/efl/ewk/ewk_view_single.cpp:403
> +    if (!smartData)

This should come earlier since you've used smartData already twice before this check.

[Mariusz Grzegorczyk]

Created attachment 145578 [details]
Fix scroll issue in single backing store when ::-webkit-scrollbar css style is used.

Rebased.

[Mariusz Grzegorczyk]

(In reply to comment #5)
> (From update of attachment 139816 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=139816&action=review
> 
> > Source/WebKit/efl/ewk/ewk_private.h:245
> > +bool ewk_frame_scrollbars_size_get(const Evas_Object* ewkFrame, int* width, int* height);
> 
> This needs to be moved to ewk_frame_private.h now.

Done.


> 
> > Source/WebKit/efl/ewk/ewk_view_single.cpp:403
> > +    if (!smartData)
> 
> This should come earlier since you've used smartData already twice before this check.

Done.

[Gyuyoung Kim]

Comment on attachment 145578 [details]
Fix scroll issue in single backing store when ::-webkit-scrollbar css style is used.

View in context: https://bugs.webkit.org/attachment.cgi?id=145578&action=review

> Source/WebKit/efl/ewk/ewk_frame.cpp:1894
> + * @param o frame object to get the size of scrollbars

o -> ewkFrame.

> Source/WebKit/efl/ewk/ewk_frame.cpp:1895
> + * @param w the pointer to store the width of vertical scrollbar, may be @c 0

w -> width.

> Source/WebKit/efl/ewk/ewk_frame.cpp:1896
> + * @param h the pointer to store the height of horizontal scrollbar, may be @c 0

h -> height.

[Mariusz Grzegorczyk]

Created attachment 145761 [details]
Fix scroll issue in single backing store when ::-webkit-scrollbar css style is used.

Applied Gyuyoung's comments.

[Adam Barth]

Comment on attachment 139816 [details]
Fix scroll issue in single backing store when ::-webkit-scrollbar css style is used.

Cleared review? from obsolete attachment 139816 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).

[Gyuyoung Kim]

Comment on attachment 145761 [details]
Fix scroll issue in single backing store when ::-webkit-scrollbar css style is used.

View in context: https://bugs.webkit.org/attachment.cgi?id=145761&action=review

I'm not proper person for this patch. CC'ing Rafael, could you review this patch ?

> Source/WebKit/efl/ewk/ewk_frame.cpp:1898
> + * @return @c EINA_TRUE on success, @c EINA_FALSE otherwise and values are zeroed.

Nit : Use true / false instead of EINA_TRUE / EINA_FALSE.

> Source/WebKit/efl/ewk/ewk_view_single.cpp:349
> +    ewk_frame_visible_content_geometry_get(smartData->main_frame, EINA_FALSE, 0, 0, &width, &height);

Nit : EINA_FALSE -> false.

[Gyuyoung Kim]

Comment on attachment 145761 [details]
Fix scroll issue in single backing store when ::-webkit-scrollbar css style is used.

Any update ?

[JungJik Lee]

Any update this issue?

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 145761 [details]
Fix scroll issue in single backing store when ::-webkit-scrollbar css style is used.

View in context: https://bugs.webkit.org/attachment.cgi?id=145761&action=review

Are all the changes to the resize code necessary? I could only reproduce this bug when scrolling, not when resizing.

Additionally, it would be good to track the issue that the custom scrollbars are simply not painted at all in WK1.

> Source/WebKit/efl/ewk/ewk_frame_private.h:34
> +class HistoryItem;
> +class HTMLPlugInElement;
> +class IntSize;
> +class KURL;

Is this related?

> Source/WebKit/efl/ewk/ewk_frame_private.h:41
> +namespace WTF {
> +class String;
> +}

Ditto.

[Mariusz Grzegorczyk]

*** This bug has been marked as a duplicate of bug 77325 ***