Bug 85367

Summary:

[webkit-patch] Return meaningful results from single-result queries.

Product:

WebKit

Reporter:

Gavin Peters <gavinp>

Component:

New Bugs

Assignee:

Gavin Peters <gavinp>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dpranke, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Gavin Peters 2012-05-02 05:14:16 PDT

[webkit-patch] Return meaningful results from single-result queries.

Comment 1 Gavin Peters 2012-05-02 05:15:56 PDT

Created attachment 139792 [details]
Patch

Comment 2 Gavin Peters 2012-05-02 05:42:55 PDT

While hacking at bug 85368, I found this bug in bugzilla.py.  The fix is a bit hacky, but strictly superior to the old behaviour.

dpranke, WDYT?

Comment 3 Dirk Pranke 2012-05-02 14:30:32 PDT

Comment on attachment 139792 [details]
Patch

Can you write a test for this?

Comment 4 Gavin Peters 2012-05-07 08:38:58 PDT

This change is tricky to write a test for; right now our bugzilla tests are one layer higher: we presume the fetch routines work, and just test the parsers.  This isn't to say we shouldn't test our fetching routines (notice this is a bug fix for them!), but that we don't have a way to do that right now.

I'm investigating.

Comment 5 WebKit Review Bot 2012-05-08 06:39:06 PDT

Comment on attachment 139792 [details]
Patch

Clearing flags on attachment: 139792

Committed r116415: <http://trac.webkit.org/changeset/116415>

Comment 6 WebKit Review Bot 2012-05-08 06:39:10 PDT

All reviewed patches have been landed.  Closing bug.