Bug 85367

Summary: [webkit-patch] Return meaningful results from single-result queries.
Product: WebKit Reporter: Gavin Peters <gavinp>
Component: New BugsAssignee: Gavin Peters <gavinp>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Gavin Peters
Reported 2012-05-02 05:14:16 PDT
[webkit-patch] Return meaningful results from single-result queries.
Attachments
Patch (1.82 KB, patch)
2012-05-02 05:15 PDT, Gavin Peters 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Peters
Comment 1 2012-05-02 05:15:56 PDT
Created attachment 139792 [details] Patch
Gavin Peters
Comment 2 2012-05-02 05:42:55 PDT
While hacking at bug 85368, I found this bug in bugzilla.py. The fix is a bit hacky, but strictly superior to the old behaviour. dpranke, WDYT?
Dirk Pranke
Comment 3 2012-05-02 14:30:32 PDT
Comment on attachment 139792 [details] Patch Can you write a test for this?
Gavin Peters
Comment 4 2012-05-07 08:38:58 PDT
This change is tricky to write a test for; right now our bugzilla tests are one layer higher: we presume the fetch routines work, and just test the parsers. This isn't to say we shouldn't test our fetching routines (notice this is a bug fix for them!), but that we don't have a way to do that right now. I'm investigating.
WebKit Review Bot
Comment 5 2012-05-08 06:39:06 PDT
Comment on attachment 139792 [details] Patch Clearing flags on attachment: 139792 Committed r116415: <http://trac.webkit.org/changeset/116415>
WebKit Review Bot
Comment 6 2012-05-08 06:39:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.