Bug 85362

Summary: Disallow unquoted -webkit-font-feature-settings tags
Product: WebKit Reporter: Kenichi Ishibashi <bashi>
Component: CSSAssignee: Kenichi Ishibashi <bashi>
Status: RESOLVED FIXED    
Severity: Normal CC: jdaggett, macpherson, menard, mitz, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kenichi Ishibashi
Reported 2012-05-02 03:46:49 PDT
John Daggett’s proposal to restrict syntax of font-feature-settings to well-formed OpenType tags accepted (http://www.w3.org/blog/CSS/2012/04/26/resolutions-32/) and the draft spec was updated(http://dev.w3.org/csswg/css3-fonts/#font-feature-settings-prop). We should disallow unquoted tags.
Attachments
Patch (6.35 KB, patch)
2012-05-02 03:52 PDT, Kenichi Ishibashi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenichi Ishibashi
Comment 1 2012-05-02 03:52:42 PDT
Created attachment 139784 [details] Patch
Kent Tamura
Comment 2 2012-05-06 19:02:44 PDT
Comment on attachment 139784 [details] Patch Looks good.
Kenichi Ishibashi
Comment 3 2012-05-06 19:35:25 PDT
Comment on attachment 139784 [details] Patch Thanks!
WebKit Review Bot
Comment 4 2012-05-06 20:12:29 PDT
Comment on attachment 139784 [details] Patch Clearing flags on attachment: 139784 Committed r116263: <http://trac.webkit.org/changeset/116263>
WebKit Review Bot
Comment 5 2012-05-06 20:12:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.