Summary: | Don't allocate stencil buffer if stencil flag is false in context creation attributes | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenneth Russell <kbr> | ||||
Component: | WebGL | Assignee: | Kenneth Russell <kbr> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dglazkov, dino, fishd, gman, twiz, webkit.review.bot, zmo | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 85338 | ||||||
Attachments: |
|
Description
Kenneth Russell
2012-05-01 15:26:04 PDT
Firefox bugs that were filed because of Chromium's behavior: https://bugzilla.mozilla.org/show_bug.cgi?id=648883 https://bugzilla.mozilla.org/show_bug.cgi?id=745880 Created attachment 139703 [details]
Patch
Comment on attachment 139703 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139703&action=review LGTM. I wonder if this CL is a sign of a trend where we will have to push similar validation up to the webgl rendering context . . . > LayoutTests/fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:18 > +precision mediump float; If I understand correctly, webgl shaders always should support the precision specifier. Is there a reason why this was previously highp? Making the change to mediump just for the sake of cleaning up? (In reply to comment #3) > (From update of attachment 139703 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=139703&action=review > > LGTM. > > I wonder if this CL is a sign of a trend where we will have to push similar validation up to the webgl rendering context . . . > > > LayoutTests/fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:18 > > +precision mediump float; > > If I understand correctly, webgl shaders always should support the precision specifier. Is there a reason why this was previously highp? Making the change to mediump just for the sake of cleaning up? LGTM. Originally we used highp in most of conformance tests, and later we cleaned it up because highp support in fragment shader is optional. I think this test was checked into webkit before the cleanup, and now it's only a sync to the khronos which has the cleanup. Comment on attachment 139703 [details]
Patch
rs=me. If zmo says LGTM, I tend to agree.
(In reply to comment #3) > I wonder if this CL is a sign of a trend where we will have to push similar validation up to the webgl rendering context . . . Yes, I think it is; see dependent bug 85338. Comment on attachment 139703 [details] Patch Clearing flags on attachment: 139703 Committed r115870: <http://trac.webkit.org/changeset/115870> All reviewed patches have been landed. Closing bug. |