Bug 85315

Summary: IndexedDB: Remove legacy enum-based constants from IDL
Product: WebKit Reporter: Alec Flett <alecflett>
Component: WebCore Misc.Assignee: David Grogan <dgrogan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dgrogan, jsbell, ojan, peter, webkit.review.bot
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 84894    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for landing none

Alec Flett
Reported 2012-05-01 14:59:05 PDT
After a few months/releases, we should remove the following constants from their respective IDL - there are constant strings that are now the standard: IDBCursor.PREV IDBCuroor.PREV_NO_DUPLICATE IDBCursor.NEXT IDBCursor.NEXT_NO_DUPLICATE IDBTransaction.READ_ONLY IDBTransaction.READ_WRITE Strawman date: 12-Aug-2012
Attachments
Patch (30.54 KB, patch)
2012-11-19 18:36 PST, David Grogan 		no flags
DetailsFormatted DiffDiff
Patch for landing (30.74 KB, patch)
2012-11-20 12:17 PST, David Grogan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Grogan
Comment 1 2012-11-19 18:36:27 PST
Created attachment 175109 [details] Patch
David Grogan
Comment 2 2012-11-19 18:37:16 PST
Alec, Josh, could you take a look at this?
Alec Flett
Comment 3 2012-11-19 21:17:19 PST
Comment on attachment 175109 [details] Patch LGTM.. good riddens!
Adam Barth
Comment 4 2012-11-19 23:43:01 PST
Comment on attachment 175109 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175109&action=review > Source/WebCore/ChangeLog:8 > + > + Tests - legacy-constants.html It would be good to add some explanation to the ChangeLog. For example, you could say that these were removed from the final spec and that Firefox doesn't support them.
David Grogan
Comment 5 2012-11-20 12:17:38 PST
Created attachment 175262 [details] Patch for landing
David Grogan
Comment 6 2012-11-20 12:19:55 PST
(In reply to comment #4) > (From update of attachment 175109 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=175109&action=review > > > Source/WebCore/ChangeLog:8 > > + > > + Tests - legacy-constants.html > > It would be good to add some explanation to the ChangeLog. For example, you could say that these were removed from the final spec and that Firefox doesn't support them. SG, added. Firefox supports these constants (as of 18.0a2) but I suppose one of us has to remove them first.
WebKit Review Bot
Comment 7 2012-11-20 13:11:04 PST
Comment on attachment 175262 [details] Patch for landing Clearing flags on attachment: 175262 Committed r135308: <http://trac.webkit.org/changeset/135308>
WebKit Review Bot
Comment 8 2012-11-20 13:11:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.