Bug 85315

Summary: IndexedDB: Remove legacy enum-based constants from IDL
Product: WebKit Reporter: Alec Flett <alecflett>
Component: WebCore Misc.Assignee: David Grogan <dgrogan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dgrogan, jsbell, ojan, peter, webkit.review.bot
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 84894    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Alec Flett 2012-05-01 14:59:05 PDT
After a few months/releases, we should remove the following constants from their respective IDL - there are constant strings that are now the standard:

IDBCursor.PREV
IDBCuroor.PREV_NO_DUPLICATE
IDBCursor.NEXT
IDBCursor.NEXT_NO_DUPLICATE
IDBTransaction.READ_ONLY
IDBTransaction.READ_WRITE

Strawman date: 12-Aug-2012
Comment 1 David Grogan 2012-11-19 18:36:27 PST
Created attachment 175109 [details]
Patch
Comment 2 David Grogan 2012-11-19 18:37:16 PST
Alec, Josh, could you take a look at this?
Comment 3 Alec Flett 2012-11-19 21:17:19 PST
Comment on attachment 175109 [details]
Patch

LGTM.. good riddens!
Comment 4 Adam Barth 2012-11-19 23:43:01 PST
Comment on attachment 175109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175109&action=review

> Source/WebCore/ChangeLog:8
> +
> +        Tests - legacy-constants.html

It would be good to add some explanation to the ChangeLog.  For example, you could say that these were removed from the final spec and that Firefox doesn't support them.
Comment 5 David Grogan 2012-11-20 12:17:38 PST
Created attachment 175262 [details]
Patch for landing
Comment 6 David Grogan 2012-11-20 12:19:55 PST
(In reply to comment #4)
> (From update of attachment 175109 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=175109&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +
> > +        Tests - legacy-constants.html
> 
> It would be good to add some explanation to the ChangeLog.  For example, you could say that these were removed from the final spec and that Firefox doesn't support them.

SG, added. Firefox supports these constants (as of 18.0a2) but I suppose one of us has to remove them first.
Comment 7 WebKit Review Bot 2012-11-20 13:11:04 PST
Comment on attachment 175262 [details]
Patch for landing

Clearing flags on attachment: 175262

Committed r135308: <http://trac.webkit.org/changeset/135308>
Comment 8 WebKit Review Bot 2012-11-20 13:11:08 PST
All reviewed patches have been landed.  Closing bug.