Summary: | IndexedDB: Remove legacy enum-based constants from IDL | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alec Flett <alecflett> | ||||||
Component: | WebCore Misc. | Assignee: | David Grogan <dgrogan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dgrogan, jsbell, ojan, peter, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | WebExposed | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 84894 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Alec Flett
2012-05-01 14:59:05 PDT
Created attachment 175109 [details]
Patch
Alec, Josh, could you take a look at this? Comment on attachment 175109 [details]
Patch
LGTM.. good riddens!
Comment on attachment 175109 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175109&action=review > Source/WebCore/ChangeLog:8 > + > + Tests - legacy-constants.html It would be good to add some explanation to the ChangeLog. For example, you could say that these were removed from the final spec and that Firefox doesn't support them. Created attachment 175262 [details]
Patch for landing
(In reply to comment #4) > (From update of attachment 175109 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=175109&action=review > > > Source/WebCore/ChangeLog:8 > > + > > + Tests - legacy-constants.html > > It would be good to add some explanation to the ChangeLog. For example, you could say that these were removed from the final spec and that Firefox doesn't support them. SG, added. Firefox supports these constants (as of 18.0a2) but I suppose one of us has to remove them first. Comment on attachment 175262 [details] Patch for landing Clearing flags on attachment: 175262 Committed r135308: <http://trac.webkit.org/changeset/135308> All reviewed patches have been landed. Closing bug. |