Bug 8531

Summary:

Added new Platform macros and using them for porting

Product:

WebKit

Reporter:

Michael Emmel <mike.emmel>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-webkit, ian

Priority:

Version:

420+

Hardware:

OS:

Linux

Bug Depends on:

Bug Blocks:

8515

Attachments:

Description	Flags
Additional Cairo and Gdk platform def	darin: review-
Patch using CAIRO PLATFORM	darin: review-
use new CAIRO Platform	darin: review-

Michael Emmel

Reported 2006-04-22 00:19:23 PDT

Added two new platform macros GDK and CAIRO used in GraphicsContext

Attachments
Additional Cairo and Gdk platform def (415 bytes, patch) 2006-04-22 00:21 PDT, Michael Emmel	darin: review-	Details Formatted Diff Diff
Patch using CAIRO PLATFORM (1.23 KB, patch) 2006-04-22 00:27 PDT, Michael Emmel	darin: review-	Details Formatted Diff Diff
use new CAIRO Platform (936 bytes, patch) 2006-04-22 00:43 PDT, Michael Emmel	darin: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Michael Emmel

Comment 1 2006-04-22 00:21:39 PDT

Created attachment 7901 [details] Additional Cairo and Gdk platform def

Michael Emmel

Comment 2 2006-04-22 00:27:51 PDT

Created attachment 7902 [details] Patch using CAIRO PLATFORM Note if the Win32 build is changed to define BUILDING_CAIRO__ the extra test for WIN32 can be removed

Michael Emmel

Comment 3 2006-04-22 00:43:48 PDT

Created attachment 7903 [details] use new CAIRO Platform

Darin Adler

Comment 4 2006-04-22 14:33:42 PDT

Comment on attachment 7902 [details] Patch using CAIRO PLATFORM There should never be a need to say "PLATFORM(CAIRO) || PLATFORM(WIN32)", so this is not correct. It should just be PLATFORM(CAIRO) and we should make sure it's set when building for Win32.

Darin Adler

Comment 5 2006-04-22 14:34:41 PDT

Comment on attachment 7901 [details] Additional Cairo and Gdk platform def This is wrong. We need to set KXMLCORE_PLATFORM_CAIRO for Win32 builds too, if it's going to exist. Also, graphics platform settings should go in a different section, not mixed in with MAC and WIN.

Darin Adler

Comment 6 2006-04-22 14:35:23 PDT

Comment on attachment 7903 [details] use new CAIRO Platform Looks good, but can't land this until we set CAIRO correctly (I review-'d the other related patches).

Darin Adler

Comment 7 2006-04-22 14:37:14 PDT

Comment on attachment 7903 [details] use new CAIRO Platform Oops, sorry, I take that back. The platform should be WIN_OS for this Win32 stuff. There is no PLATFORM(WIN32) and PLATFORM(WIN) is about the low level operating system rather than the high level operating environment (HDC and such).

Maciej Stachowiak

Comment 8 2006-04-22 16:49:27 PDT

Actually, PLATFORM(WIN) is the high level and PLATFORM(WIN_OS) is the low level. PLATFORM(WIN) would be right for these patches.

Michael Emmel

Comment 9 2006-04-22 18:11:15 PDT

(In reply to comment #8) > Actually, PLATFORM(WIN) is the high level and PLATFORM(WIN_OS) is the low > level. PLATFORM(WIN) would be right for these patches. > If you can change the patch to match I'd appreciate it also as you note it needs to be tested under Windows which I'm not set up to do.

Eric Seidel (no email)

Comment 10 2007-09-30 11:31:31 PDT

This was done long ago.

Note You need to log in before you can comment on or make changes to this bug.