Bug 8530

Summary:

Missing assert.h include

Product:

WebKit

Reporter:

Michael Emmel <mike.emmel>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

OS:

Linux

Bug Depends on:

Bug Blocks:

8515

Attachments:

Description	Flags
adds assert.h	mjs: review+
addes assert.h	mjs: review+
add assert.h	mjs: review+
add assert.h	mjs: review+
add assert.h	none
add assert.h	mjs: review+

Description Michael Emmel 2006-04-21 23:57:46 PDT

missing assert.h include

Comment 1 Michael Emmel 2006-04-21 23:58:29 PDT

Created attachment 7898 [details]
adds assert.h

Comment 2 Michael Emmel 2006-04-22 00:00:38 PDT

Created attachment 7899 [details]
addes assert.h

Comment 3 Michael Emmel 2006-04-22 00:02:04 PDT

Created attachment 7900 [details]
add assert.h

Comment 4 Michael Emmel 2006-04-22 00:45:15 PDT

Created attachment 7904 [details]
add assert.h

Comment 5 Michael Emmel 2006-04-22 00:46:31 PDT

Created attachment 7905 [details]
add assert.h

Comment 6 Michael Emmel 2006-04-22 00:47:50 PDT

Comment on attachment 7905 [details]
add assert.h

>Index: platform/image-decoders/jpeg/JPEGImageDecoder.cpp
>===================================================================
>--- platform/image-decoders/jpeg/JPEGImageDecoder.cpp	(revision 14006)
>+++ platform/image-decoders/jpeg/JPEGImageDecoder.cpp	(working copy)
>@@ -37,6 +37,7 @@
> 
> #include "config.h"
> #include "JPEGImageDecoder.h"
>+#include <assert.h>
> 
> extern "C" {
> #include "jpeglib.h"

Comment 7 Michael Emmel 2006-04-22 00:48:32 PDT

Comment on attachment 7905 [details]
add assert.h

>Index: platform/image-decoders/jpeg/JPEGImageDecoder.cpp
>===================================================================
>--- platform/image-decoders/jpeg/JPEGImageDecoder.cpp	(revision 14006)
>+++ platform/image-decoders/jpeg/JPEGImageDecoder.cpp	(working copy)
>@@ -37,6 +37,7 @@
> 
> #include "config.h"
> #include "JPEGImageDecoder.h"
>+#include <assert.h>
> 
> extern "C" {
> #include "jpeglib.h"

Comment 8 Michael Emmel 2006-04-22 00:51:49 PDT

Created attachment 7906 [details]
add assert.h

Comment 9 Maciej Stachowiak 2006-04-22 12:59:56 PDT

Comment on attachment 7906 [details]
add assert.h

r=me on all of these. For future reference though, might be better to make one patch that includes all files. Also this needs a ChangeLog entry.

Comment 10 Darin Adler 2006-04-22 14:52:26 PDT

The right form for these patches would have been one patch for all 5 of the additions of <assert.h>, along with a change log entry.

I'll land them anyway; it's a bit more work but OK this time.