Bug 8530

Summary: Missing assert.h include
Product: WebKit Reporter: Michael Emmel <mike.emmel>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 8515    
Attachments:
Description Flags
adds assert.h
mjs: review+
addes assert.h
mjs: review+
add assert.h
mjs: review+
add assert.h
mjs: review+
add assert.h
none
add assert.h mjs: review+

Michael Emmel
Reported 2006-04-21 23:57:46 PDT
missing assert.h include
Attachments
adds assert.h (308 bytes, patch)
2006-04-21 23:58 PDT, Michael Emmel 		mjs: review+
DetailsFormatted DiffDiff
addes assert.h (341 bytes, patch)
2006-04-22 00:00 PDT, Michael Emmel 		mjs: review+
DetailsFormatted DiffDiff
add assert.h (367 bytes, patch)
2006-04-22 00:02 PDT, Michael Emmel 		mjs: review+
DetailsFormatted DiffDiff
add assert.h (373 bytes, patch)
2006-04-22 00:45 PDT, Michael Emmel 		mjs: review+
DetailsFormatted DiffDiff
add assert.h (396 bytes, patch)
2006-04-22 00:46 PDT, Michael Emmel 		no flags
DetailsFormatted DiffDiff
add assert.h (396 bytes, patch)
2006-04-22 00:51 PDT, Michael Emmel 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Emmel
Comment 1 2006-04-21 23:58:29 PDT
Created attachment 7898 [details] adds assert.h
Michael Emmel
Comment 2 2006-04-22 00:00:38 PDT
Created attachment 7899 [details] addes assert.h
Michael Emmel
Comment 3 2006-04-22 00:02:04 PDT
Created attachment 7900 [details] add assert.h
Michael Emmel
Comment 4 2006-04-22 00:45:15 PDT
Created attachment 7904 [details] add assert.h
Michael Emmel
Comment 5 2006-04-22 00:46:31 PDT
Created attachment 7905 [details] add assert.h
Michael Emmel
Comment 6 2006-04-22 00:47:50 PDT
Comment on attachment 7905 [details] add assert.h >Index: platform/image-decoders/jpeg/JPEGImageDecoder.cpp >=================================================================== >--- platform/image-decoders/jpeg/JPEGImageDecoder.cpp (revision 14006) >+++ platform/image-decoders/jpeg/JPEGImageDecoder.cpp (working copy) >@@ -37,6 +37,7 @@ > > #include "config.h" > #include "JPEGImageDecoder.h" >+#include <assert.h> > > extern "C" { > #include "jpeglib.h"
Michael Emmel
Comment 7 2006-04-22 00:48:32 PDT
Comment on attachment 7905 [details] add assert.h >Index: platform/image-decoders/jpeg/JPEGImageDecoder.cpp >=================================================================== >--- platform/image-decoders/jpeg/JPEGImageDecoder.cpp (revision 14006) >+++ platform/image-decoders/jpeg/JPEGImageDecoder.cpp (working copy) >@@ -37,6 +37,7 @@ > > #include "config.h" > #include "JPEGImageDecoder.h" >+#include <assert.h> > > extern "C" { > #include "jpeglib.h"
Michael Emmel
Comment 8 2006-04-22 00:51:49 PDT
Created attachment 7906 [details] add assert.h
Maciej Stachowiak
Comment 9 2006-04-22 12:59:56 PDT
Comment on attachment 7906 [details] add assert.h r=me on all of these. For future reference though, might be better to make one patch that includes all files. Also this needs a ChangeLog entry.
Darin Adler
Comment 10 2006-04-22 14:52:26 PDT
The right form for these patches would have been one patch for all 5 of the additions of <assert.h>, along with a change log entry. I'll land them anyway; it's a bit more work but OK this time.
Note You need to log in before you can comment on or make changes to this bug.