Bug 85295

Summary: Temporarily remove webkitSourceAddId() & webkitSourceRemoveId() from DOM
Product: WebKit Reporter: Aaron Colwell <acolwell>
Component: MediaAssignee: Aaron Colwell <acolwell>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric.carlson, feature-media-reviews, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Removing LayoutTest
none
Fix ChangeLog none

Aaron Colwell
Reported 2012-05-01 10:11:01 PDT
Temporarily removing webkitSourceAddId() & webkitSourceRemoveId() from DOM until all the other Media Source v0.5 methods are supported. Implementing the other methods ended up taking longer than initially expected. The patch for full support should be ready in a week or so. In the mean time I think it makes sense to make these methods invisible to JavaScript so that there isn't confusion about whether v0.5 support is present or not.
Attachments
Patch (1.82 KB, patch)
2012-05-01 10:16 PDT, Aaron Colwell 		no flags
DetailsFormatted DiffDiff
Removing LayoutTest (13.27 KB, patch)
2012-05-01 10:42 PDT, Aaron Colwell 		no flags
DetailsFormatted DiffDiff
Fix ChangeLog (14.15 KB, patch)
2012-05-01 11:03 PDT, Aaron Colwell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Aaron Colwell
Comment 1 2012-05-01 10:16:48 PDT
Created attachment 139646 [details] Patch
Eric Carlson
Comment 2 2012-05-01 10:30:19 PDT
Comment on attachment 139646 [details] Patch What about video-media-source-add-and-remove-ids*.*?
Aaron Colwell
Comment 3 2012-05-01 10:42:40 PDT
Created attachment 139648 [details] Removing LayoutTest
Aaron Colwell
Comment 4 2012-05-01 10:43:07 PDT
(In reply to comment #2) > (From update of attachment 139646 [details]) > What about video-media-source-add-and-remove-ids*.*? The test is currently skipped because the webkitSourceAppend() patch hadn't landed yet. I was going to just leave it there, but on second thought it makes more sense to include this test when all the other methods land.
Eric Carlson
Comment 5 2012-05-01 10:54:04 PDT
Comment on attachment 139648 [details] Removing LayoutTest Oops, looks like you forgot to run prepare-ChangeLog after removing the test.
Aaron Colwell
Comment 6 2012-05-01 11:03:03 PDT
Created attachment 139651 [details] Fix ChangeLog
WebKit Review Bot
Comment 7 2012-05-01 12:27:05 PDT
Comment on attachment 139651 [details] Fix ChangeLog Clearing flags on attachment: 139651 Committed r115745: <http://trac.webkit.org/changeset/115745>
WebKit Review Bot
Comment 8 2012-05-01 12:27:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.