Bug 85294

Summary: Use HashMap<OwnPtr> for CounterMap in RenderCounter
Product: WebKit Reporter: Igor Trindade Oliveira <igor.oliveira>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jchaffraix, kling, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Igor Trindade Oliveira
Reported 2012-05-01 09:57:37 PDT
Use HashMap<OwnPtr> for CounterMap in RenderCounter
Attachments
Patch (2.67 KB, patch)
2012-05-01 10:03 PDT, Igor Trindade Oliveira 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Igor Trindade Oliveira
Comment 1 2012-05-01 10:03:11 PDT
Created attachment 139643 [details] Patch Proposed patch.
Eric Seidel (no email)
Comment 2 2012-05-01 10:30:57 PDT
Comment on attachment 139643 [details] Patch Seems reasonable. I believe it's safe to use an OwnPtr as a HashMap value.
WebKit Review Bot
Comment 3 2012-05-01 10:39:30 PDT
Comment on attachment 139643 [details] Patch Clearing flags on attachment: 139643 Committed r115736: <http://trac.webkit.org/changeset/115736>
WebKit Review Bot
Comment 4 2012-05-01 10:39:35 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 5 2012-05-02 12:34:39 PDT
Comment on attachment 139643 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139643&action=review > Source/WebCore/rendering/RenderCounter.cpp:443 > nodeMap = new CounterMap; > - counterMaps().set(object, nodeMap); > + counterMaps().set(object, adoptPtr(nodeMap)); It would have been better to do a version of this where the adoptPtr and the new are on the same line of code.
Note You need to log in before you can comment on or make changes to this bug.