Summary: | [chromium] Accept four parameters when dispatching a WebInputEvent::GestureTap in chromium DRT eventSender | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Terry Anderson <tdanderson> | ||||||||
Component: | Platform | Assignee: | Terry Anderson <tdanderson> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dpranke, eric, rjkroege, tkent, tony, webkit.review.bot, zmo | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 85314 | ||||||||||
Bug Blocks: | 83947, 85101 | ||||||||||
Attachments: |
|
Description
Terry Anderson
2012-05-01 09:16:57 PDT
Created attachment 139634 [details]
Patch
Comment on attachment 139634 [details]
Patch
What tests does this affect?
(In reply to comment #2) > (From update of attachment 139634 [details]) > What tests does this affect? fast/events/touch/gesture (in particular, gesture-click.html) The change is fine, but you should mention which (some general idea) tests this fix in the ChangeLog (and ideally include the test_expectations update in the change. When is this eventSender method needed instead of just generating a synthetic event in the JS? I see, you explain in your bug description why you need this. I think you should just copy that to your ChangeLog. :) Many reviewers (myself included) mostly just read the ChangeLog, since that's the part which is actually commited and sticks around for easy git blaming. :) Created attachment 139642 [details]
Patch
Comment on attachment 139642 [details]
Patch
Thanks.
Comment on attachment 139642 [details] Patch Clearing flags on attachment: 139642 Committed r115735: <http://trac.webkit.org/changeset/115735> All reviewed patches have been landed. Closing bug. fast/events/touch/page-scaled-touch-gesture-click.html fast/events/touch/gesture/gesture-click.html These two tests are crashing on debug bots: STDOUT: <empty> STDERR: ASSERTION FAILED: i < size() STDERR: third_party/WebKit/Source/WTF/wtf/Vector.h(532) : const T& WTF::Vector<T, inlineCapacity>::at(size_t) const [with T = CppVariant, long unsigned int inlineCapacity = 0ul] STDERR: 1 0x421be5 STDERR: 2 0x42171f STDERR: 3 0x43ab46 STDERR: 4 0x43a7c1 STDERR: 5 0x43e428 STDERR: 6 0x42b8ca STDERR: 7 0x42af87 STDERR: 8 0x1338999 STDERR: 9 0x1338b14 STDERR: 10 0xb33c10 STDERR: 11 0xb2eb84 STDERR: 12 0xb2eb55 STDERR: 13 0x1e670530618e STDERR: [26085:26085:3369300989752:ERROR:process_util_posix.cc(143)] Received signal 11 STDERR: base::debug::StackTrace::StackTrace() [0x86cfb2] STDERR: base::(anonymous namespace)::StackDumpSignalHandler() [0x82dbd1] STDERR: 0x7fd10cc31af0 STDERR: WTF::Vector<>::at() [0x421bef] STDERR: WTF::Vector<>::operator[]() [0x42171f] STDERR: EventSender::gestureEvent() [0x43ab46] STDERR: EventSender::gestureTap() [0x43a7c1] STDERR: CppBoundClass::MemberCallback<>::run() [0x43e428] STDERR: CppBoundClass::invoke() [0x42b8ca] STDERR: CppNPObject::invoke() [0x42af87] STDERR: WebCore::npObjectInvokeImpl() [0x1338999] STDERR: WebCore::npObjectMethodHandler() [0x1338b14] STDERR: v8::internal::HandleApiCallHelper<>() [0xb33c10] STDERR: v8::internal::Builtin_Impl_HandleApiCall() [0xb2eb84] STDERR: v8::internal::Builtin_HandleApiCall() [0xb2eb55] STDERR: 0x1e670530618e I carelessly forgot to check the size of |arguments|, which caused two tests to crash. The landed patch was rolled out by Zhenyao, so I am about to upload a new one that will not break any tests. Created attachment 139699 [details]
Patch
Comment on attachment 139699 [details]
Patch
ok.
Comment on attachment 139699 [details] Patch Clearing flags on attachment: 139699 Committed r115767: <http://trac.webkit.org/changeset/115767> All reviewed patches have been landed. Closing bug. |