Bug 85280

Summary: [CG] Minor refactor of ImageBuffer::CGImageToDataURL and its callers
Product: WebKit Reporter: noel gordon <noel.gordon>
Component: New BugsAssignee: noel gordon <noel.gordon>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, kbr, mitz, thorton, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

noel gordon
Reported 2012-05-01 06:59:09 PDT
[CG] Minor refactor of ImageBuffer::CGImageToDataURL and its callers
Attachments
Patch (5.60 KB, patch)
2012-05-01 07:05 PDT, noel gordon 		no flags
DetailsFormatted DiffDiff
Patch (5.73 KB, patch)
2012-05-03 22:15 PDT, noel gordon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
noel gordon
Comment 1 2012-05-01 07:05:09 PDT
Created attachment 139621 [details] Patch
noel gordon
Comment 2 2012-05-03 22:15:49 PDT
Created attachment 140157 [details] Patch
noel gordon
Comment 3 2012-05-03 22:16:39 PDT
Adding Kenneth for the webgl aspect.
noel gordon
Comment 4 2012-05-03 22:45:00 PDT
canvas/philip/tests/toDataURL* and fast/canvas/webgl/premultiplyalpha-test.html are passing locally for me with this change.
Kenneth Russell
Comment 5 2012-05-04 13:29:16 PDT
Comment on attachment 140157 [details] Patch Looks fine. r=me
WebKit Review Bot
Comment 6 2012-05-04 17:49:00 PDT
Comment on attachment 140157 [details] Patch Clearing flags on attachment: 140157 Committed r116196: <http://trac.webkit.org/changeset/116196>
WebKit Review Bot
Comment 7 2012-05-04 17:49:04 PDT
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 8 2012-05-07 01:08:11 PDT
Noticed the alpha channel stuffing to 255 similar to bug 84319. Again we could tell the CG JPEG image encoder to just ignore the alpha channel. Filed bug 85779 about that.
Note You need to log in before you can comment on or make changes to this bug.