Bug 85265

Summary: [Shadow DOM] ShadowTree needs a better name
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: DOMAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric.carlson, eric, feature-media-reviews, gustavo, philn, rakuco, tkent, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85263    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Hajime Morrita 2012-04-30 23:17:59 PDT 
This is part of the refactoring series Bug 85263.

ShadowTree is confusing name because it's a stack of tree, not tree itself.
On the other hand, the original intention of the class was that Shadow DOM concept should
be isolated from non-shadow part. This idea has been making sense. What we need is just a good name.
Comment 1 Hajime Morrita 2012-05-01 00:24:21 PDT 
Created attachment 139597 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2012-05-01 00:33:36 PDT 
Comment on attachment 139597 [details]
Patch

Attachment 139597 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12581585
Comment 3 Early Warning System Bot 2012-05-01 00:54:03 PDT 
Comment on attachment 139597 [details]
Patch

Attachment 139597 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12587504
Comment 4 Build Bot 2012-05-01 00:56:19 PDT 
Comment on attachment 139597 [details]
Patch

Attachment 139597 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12595429
Comment 5 Early Warning System Bot 2012-05-01 00:59:05 PDT 
Comment on attachment 139597 [details]
Patch

Attachment 139597 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12586548
Comment 6 Build Bot 2012-05-01 01:01:58 PDT 
Comment on attachment 139597 [details]
Patch

Attachment 139597 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12590509
Comment 7 WebKit Review Bot 2012-05-01 01:27:18 PDT 
Comment on attachment 139597 [details]
Patch

Attachment 139597 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12598327
Comment 8 Gyuyoung Kim 2012-05-01 06:12:13 PDT 
Comment on attachment 139597 [details]
Patch

Attachment 139597 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12595486
Comment 9 Dimitri Glazkov (Google) 2012-05-01 09:14:26 PDT 
I like new names.
Comment 10 Dimitri Glazkov (Google) 2012-05-01 09:15:12 PDT 
Comment on attachment 139597 [details]
Patch

rs=me, but please make it build first.
Comment 11 Hajime Morrita 2012-05-06 18:27:56 PDT 
(In reply to comment #10)
> (From update of attachment 139597 [details])
> rs=me, but please make it build first.
gah, what were I doing...
Comment 12 Hajime Morrita 2012-05-06 18:33:22 PDT 
Created attachment 140447 [details]
Patch
Comment 13 Build Bot 2012-05-06 19:00:04 PDT 
Comment on attachment 140447 [details]
Patch

Attachment 140447 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12628891
Comment 14 Hajime Morrita 2012-05-06 20:54:54 PDT 
Created attachment 140466 [details]
Patch
Comment 15 WebKit Review Bot 2012-05-06 23:05:02 PDT 
Comment on attachment 140466 [details]
Patch

Clearing flags on attachment: 140466

Committed r116277: <http://trac.webkit.org/changeset/116277>
Comment 16 WebKit Review Bot 2012-05-06 23:05:09 PDT 
All reviewed patches have been landed.  Closing bug.