Bug 85260

Summary: Early-out and avoid any copying when possible for Region operations
Product: WebKit Reporter: Dana Jansens <danakj>
Component: New BugsAssignee: Dana Jansens <danakj>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, backer, dglazkov, enne, gustavo, jamesr, piman, pnormand, vangelis, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 81076    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Dana Jansens
Reported 2012-04-30 22:08:25 PDT
Early-out and avoid any copying when possible for Region operations
Attachments
Patch (3.93 KB, patch)
2012-04-30 22:14 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch (7.62 KB, patch)
2012-05-08 18:11 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch (7.78 KB, patch)
2012-05-09 08:30 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2012-04-30 22:14:32 PDT
Created attachment 139581 [details] Patch
WebKit Review Bot
Comment 2 2012-04-30 22:17:47 PDT
Comment on attachment 139581 [details] Patch Attachment 139581 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12585513
Philippe Normand
Comment 3 2012-04-30 22:18:42 PDT
Comment on attachment 139581 [details] Patch Attachment 139581 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12592461
Dana Jansens
Comment 4 2012-04-30 22:19:53 PDT
Comment on attachment 139581 [details] Patch This won't compile without bug #81076.
Early Warning System Bot
Comment 5 2012-04-30 22:20:47 PDT
Comment on attachment 139581 [details] Patch Attachment 139581 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12584513
Early Warning System Bot
Comment 6 2012-04-30 22:20:54 PDT
Comment on attachment 139581 [details] Patch Attachment 139581 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12584514
Build Bot
Comment 7 2012-04-30 22:29:21 PDT
Comment on attachment 139581 [details] Patch Attachment 139581 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12585519
Build Bot
Comment 8 2012-04-30 22:39:12 PDT
Comment on attachment 139581 [details] Patch Attachment 139581 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12587477
Gyuyoung Kim
Comment 9 2012-05-01 05:22:58 PDT
Comment on attachment 139581 [details] Patch Attachment 139581 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/12587542
Dana Jansens
Comment 10 2012-05-08 18:11:12 PDT
Created attachment 140835 [details] Patch
Build Bot
Comment 11 2012-05-08 18:57:31 PDT
Comment on attachment 140835 [details] Patch Attachment 140835 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12647499
Dana Jansens
Comment 12 2012-05-09 08:30:36 PDT
Created attachment 140952 [details] Patch
Anders Carlsson
Comment 13 2012-05-09 09:13:44 PDT
Comment on attachment 140952 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140952&action=review > Source/WebKit/chromium/tests/RegionTest.cpp:390 > + r. unite(IntRect(0, 0, 500, 500)); Extra space here
WebKit Review Bot
Comment 14 2012-05-09 10:00:34 PDT
Comment on attachment 140952 [details] Patch Clearing flags on attachment: 140952 Committed r116538: <http://trac.webkit.org/changeset/116538>
WebKit Review Bot
Comment 15 2012-05-09 10:00:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.