Summary: | [chromium] CCProxy's shouldn't try to draw if there is no layer renderer | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | vollick | ||||||||||||
Component: | WebKit Misc. | Assignee: | vollick | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | cc-bugs, jamesr, nduca, webkit.review.bot | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
vollick
2012-04-30 11:26:25 PDT
Created attachment 139488 [details]
Patch
Attachment 139488 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 139493 [details]
Patch
Attachment 139493 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 139496 [details]
Patch
Removed assert -- should be valid to try and draw without a renderer. Should just fail.
Comment on attachment 139496 [details]
Patch
What causes this to happen?
Created attachment 139624 [details] Patch (In reply to comment #6) > (From update of attachment 139496 [details]) > What causes this to happen? I'm not sure. Looking at http://code.google.com/p/chromium/issues/detail?id=125482, it appears the only culprit could be a null renderer. I would also like to know how we get in this state, but in the short term, it would be nice to avoid the crash. Comment on attachment 139624 [details]
Patch
I'm still really confused how this could happen, other than maybe prior to initializeLayerRenderer.
I think canDraw() should also return false in this case so that we don't draw unless forced to.
Created attachment 140068 [details] Patch (In reply to comment #8) > (From update of attachment 139624 [details]) > I'm still really confused how this could happen, other than maybe prior to initializeLayerRenderer. > > I think canDraw() should also return false in this case so that we don't draw unless forced to. Good idea. Done. Comment on attachment 140068 [details]
Patch
R=me.
Comment on attachment 140068 [details] Patch Clearing flags on attachment: 140068 Committed r116152: <http://trac.webkit.org/changeset/116152> All reviewed patches have been landed. Closing bug. |