Summary: | MediaStream should not be an ActiveDOMObject | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Bergkvist <adam.bergkvist> | ||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, eric.carlson, feature-media-reviews, ojan, per-erik.brodin, tommyw, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Adam Bergkvist
2012-04-30 07:16:03 PDT
Created attachment 139448 [details]
Proposed patch
After discussing this with Adam I agree that this is the best solution. Comment on attachment 139448 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=139448&action=review I didn't quite follow all the details in Comment #0, but if you and Tommy agree that this is the right thing to do, I'm willing to believe it. :) > Source/WebCore/ChangeLog:8 > + Made MediaStream a ContextDestructionObserver instead. Consider copying the text from comment #0 in the but to the ChangeLog. That's really helpful information and it would be nice to have it in the ChangeLog rather than a click away in the bug. Thank you. I'll update the ChangeLog before committing. Will you be committing this patch soon? I'll commit it today. Created attachment 140518 [details]
Patch for landing
Comment on attachment 140518 [details] Patch for landing Clearing flags on attachment: 140518 Committed r116311: <http://trac.webkit.org/changeset/116311> All reviewed patches have been landed. Closing bug. |