Bug 8514

Summary:

Web Inspector hides when the app is in the background

Product:

WebKit

Reporter:

Matt Gough <matt>

Component:

Web Inspector (Deprecated)

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Minor

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Adds a 'Hides in Background' menu item to the Web Inspector window	darin: review-
New patch	eric: review+

Matt Gough

Reported 2006-04-21 07:26:01 PDT

Often when I am debugging my own app, I keep the same web page open in Safari with the Web Inspector open. This way I can easily inspect the same DOM that I am stepping through in the debugger. However, it is annoying that that window hides itself when Safari is not at the front as I have to keep switching between the debugger in XCode and Safari. Therefore I have created a patch which adds a 'Hides in Background' option to the pop-up menu show in the top-right corner of the Inspector.

Attachments
Adds a 'Hides in Background' menu item to the Web Inspector window (1.11 KB, patch) 2006-04-21 07:29 PDT, Matt Gough	darin: review-	Details Formatted Diff Diff
New patch (3.53 KB, patch) 2006-04-22 16:32 PDT, Timothy Hatcher	eric: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Matt Gough

Comment 1 2006-04-21 07:29:06 PDT

Created attachment 7869 [details] Adds a 'Hides in Background' menu item to the Web Inspector window

Darin Adler

Comment 2 2006-04-21 22:07:10 PDT

Comment on attachment 7869 [details] Adds a 'Hides in Background' menu item to the Web Inspector window Do we really need a menu item for this? Can't we just decide which way it should work?

Darin Adler

Comment 3 2006-04-21 22:07:51 PDT

I'm thinking it's better to just change the setting to not hide in background. We should ask Tim Hatcher what he thinks.

Dave Hyatt

Comment 4 2006-04-21 23:59:58 PDT

I personally think the default should be not to hide. I can't stand that behavior in "debugging" windows like the Snippet Editor and the Web Inspector, since often you need to look at them while bringing another app to the front.

Matt Gough

Comment 5 2006-04-22 03:20:43 PDT

I did consider just setting it to not hide, but maybe some people like the behaviour. Personally I would default it to not hiding, but keep the menu in case people need it to for some reason. Its not as if it takes up any extra space in the UI

Maciej Stachowiak

Comment 6 2006-04-22 13:15:53 PDT

I agree that we should just change the behavior to not hide in the background. That seems better than the menu. I don't think there's a great need to offer the hiding behavior as well.

Darin Adler

Comment 7 2006-04-22 14:37:56 PDT

Comment on attachment 7869 [details] Adds a 'Hides in Background' menu item to the Web Inspector window We have consensus now that we want to turn hidesOnDeactivate off completely rather than adding a menu item. Also need a change log entry.

Timothy Hatcher

Comment 8 2006-04-22 16:32:56 PDT

Created attachment 7917 [details] New patch Makes the inspector not hide in the background. Since the inspector is a floating panel we need to call setFloatingPanel:NO when the app is switching into the background. Then call setFloatingPanel:YES when the app is activated again. Withouth this the inspector would float above all applications.

Eric Seidel (no email)

Comment 9 2006-04-22 16:43:12 PDT

Comment on attachment 7917 [details] New patch Looks fine. r=me.

Timothy Hatcher

Comment 10 2006-04-22 16:44:38 PDT

Landed in r14020.

Note You need to log in before you can comment on or make changes to this bug.