Bug 8511 – onerror JS property does not register listener properly

• Component: WebCore JavaScript
• Status: RESOLVED FIXED

[Maciej Stachowiak]

The onerror JS property doesn't properly register an error listener on img elements (the onerror HTML attribute does):

<img src="http://www.google.com/intl/en/images/logo.giffff" id="foo">
<script>
document.getElementById("foo").onerror = function(event) { alert('error property'); };
</script>

I believe this is because in kjs_dom.cpp the bindings code registers a listener for khtmlErrorEvent instead of errorEvent for this property.

[Jon]

Created attachment 7875 [details]
Patch using maciej's fix.

Here's a patch using Maciej's suggested fix.

[Geoffrey Garen]

Created attachment 7876 [details]
test case

[Geoffrey Garen]

Comment on attachment 7875 [details]
Patch using maciej's fix.

we talked about this on irc -- no changelog, no test case, doesn't fix window.onerror.

[Jon]

Created attachment 7879 [details]
Patch plus test case.

[Jon]

Created attachment 7880 [details]
Better patch and test case.

[Jon]

Created attachment 7882 [details]
Patch with working test and results.

[Geoffrey Garen]

Comment on attachment 7882 [details]
Patch with working test and results.

r=me

[Eric Seidel (no email)]

Sweet!  A new contributer!  Now we just need to convince Jon to join us on #webkit. :)

[Darin Adler]

Yes, removes khtmlError entirely! Hooray!

[Alexey Proskuryakov]

*** Bug 6688 has been marked as a duplicate of this bug. ***