Bug 8510

Summary: submit event doesn't bubble - it's supposed to.
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: FormsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal Keywords: EasyFix
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Fix sullivan: review+

Maciej Stachowiak
Reported 2006-04-21 00:11:40 PDT
Here's a simple test case: <div onsubmit="alert('submit')"> <form action="?foo"> <input type="submit"> The alert fires in other browsers. I suspect this is just a matter of changing false to true on this line of HTMLFormElement.cpp: if ( dispatchHTMLEvent(submitEvent,false,true) && !m_doingsubmit )
Attachments
Fix (4.70 KB, patch)
2006-04-21 14:42 PDT, Geoffrey Garen 		sullivan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2006-04-21 12:56:41 PDT
I'm on it.
Geoffrey Garen
Comment 2 2006-04-21 14:42:26 PDT
Created attachment 7885 [details] Fix
John Sullivan
Comment 3 2006-04-21 16:29:24 PDT
Comment on attachment 7885 [details] Fix nice and simple
Geoffrey Garen
Comment 4 2006-04-22 00:29:39 PDT
Landed.
Note You need to log in before you can comment on or make changes to this bug.