Bug 85075
| Summary: | check0webkit-style gives false alphabetization error with JSDOMWindowCustom | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Joe Mason <joenotcharles> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Joe Mason
In https://bugs.webkit.org/show_bug.cgi?id=84982, the stylebot complained about this header include in JSDOMWindowWebSocketCustom.cpp:
23 #include "config.h"
24 #include "JSDOMWindowCustom.h"
25
26 #if ENABLE(WEB_SOCKETS)
27 #include "Frame.h"
28 #include "JSWebSocket.h"
29 #include "Settings.h"
30
31 #if PLATFORM(BLACKBERRY)
32 #include "WebSocket.h"
33 #endif
...
65 #endif
Source/WebCore/bindings/js/JSDOMWindowWebSocketCustom.cpp:32: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
The header this file implements in JSDOMWindowCustom.h. WebSocket.h contains helper functions. I think the problem is that JSDOMWindowCustom.h does not exactly match the cpp file name, and it's finding "WebSocket" as a substring of the .cpp file name.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Joe Mason
In bug 85005:
>> Source/WebCore/platform/chromium/support/WebPrerender.cpp:37
>> +#include "Prerender.h"
>
> Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Again, Prerender is a substring of WebPrerender, but is not the "primary header".