Bug 85068

Summary: [Gtk][DOM Bindings] Feature-protected properties are put under condition guards
Product: WebKit Reporter: Zan Dobersek <zan>
Component: WebKitGTKAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, japhet, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2012-04-27 08:10:37 PDT
When generating DOM bindings, if a property is feature-enabled, that property is generated with condition guards around it. This means that that property might not be present in a build that disables that feature. This leads to inconsistent ABI, which is unwanted. Instead of that, all the properties should be present, but when trying to get (or set if writable) the value of a feature-dependent property, a warning should be emitted if the feature was not enabled at compile time. Similarly, if the complete DOM object is feature-dependent, all the properties should still be present but getting or setting the value should throw a warning if that feature was not enabled at compile time.
Attachments
Patch (23.83 KB, patch)
2012-04-27 09:13 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2012-04-27 09:13:20 PDT
Created attachment 139215 [details] Patch
Zan Dobersek
Comment 2 2012-04-27 09:34:42 PDT
Comment on attachment 139215 [details] Patch Clearing flags on attachment: 139215 Committed r115442: <http://trac.webkit.org/changeset/115442>
Zan Dobersek
Comment 3 2012-04-27 09:34:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.