Bug 85055

Summary: HTML5 "hidden" attribute is overridden by CSS "display" property
Product: WebKit Reporter: dubroy
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: ap, eoconnor, ian, kling, koivisto, simon.fraser, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
Attachments:
Description Flags
Sample that reproduces the bug none

dubroy
Reported 2012-04-27 05:33:37 PDT
Created attachment 139175 [details] Sample that reproduces the bug When an element has the "hidden" attribute, it will be visible if a matching CSS rule includes the "display" property. Example: <!doctype html> <html><head><title></title></head> <body> <style> p { display: inline-block; } </style> <p hidden>Blah</p> </body> </html> In WebKit nightly & Chrome Canary, the text "Blah" is visible. I believe it should be hidden. If I remove the "display" line, it is hidden as expected.
Attachments
Sample that reproduces the bug (158 bytes, text/html)
2012-04-27 05:33 PDT, dubroy 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2012-04-27 10:28:46 PDT
Curious why HTML5 adds new presentation information to markup. > I believe it should be hidden. Could you please elaborate why it should be hidden? It's easier to people reading the bug if they don't have to redo the research you already did.
dubroy
Comment 2 2012-04-27 10:37:33 PDT
From the spec (http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#the-hidden-attribute): "User agents should not render elements that have the hidden attribute specified." In the example I gave, I'd expect the paragraph to be hidden because the hidden attribute is on the element itself, and the CSS rule applies to all <p> elements. The hidden attribute should take precedence, just like if I put "display: none" in the element's style.
Theresa O'Connor
Comment 3 2012-05-01 10:50:24 PDT
The rendering section suggests hidden="" is equivalent to "display: none", not "display: none !important": http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html#hidden-elements So I think our behavior matches the spec.
dubroy
Comment 4 2012-05-01 10:57:10 PDT
(In reply to comment #3) > The rendering section suggests hidden="" is equivalent to "display: none", not "display: none !important": > > http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html#hidden-elements > > So I think our behavior matches the spec. But wouldn't the attribute be considered more specific? If I replace: <p hidden> with <p style="display:none"> then the element is hidden. If hidden is supposed to be the same as "display: none", then I'd expect those two things to behave the same.
Theresa O'Connor
Comment 5 2012-05-01 11:22:05 PDT
The specificity of [hidden] is {0,0,1,0}, whereas the specificity of style="display:none" is {1,0,0,0}. So no, there's no reason to expect those to behave the same way.
dubroy
Comment 6 2012-05-02 05:29:54 PDT
You're right, the current WebKit behaviour appears to match the wording of the spec. I don't think it *should* behave that way, but this is the wrong place for discussion.
Note You need to log in before you can comment on or make changes to this bug.