Bug 85045

Summary: Fix minimal build.
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: WebKit QtAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Allan Sandfeld Jensen 2012-04-27 03:17:23 PDT
Build with --minimal currently fails because it makes multiple conflicting definition of ENABLE_XSLT.
Comment 1 Allan Sandfeld Jensen 2012-04-27 03:20:16 PDT
Created attachment 139161 [details]
Patch
Comment 2 Tor Arne Vestbø 2012-04-27 05:55:18 PDT
Comment on attachment 139161 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139161&action=review

> Source/WebCore/Target.pri:2914
> +} else {
> +    HEADERS += xml/parser/XMLDocumentParserScope.h
> +    SOURCES += \
> +            xml/parser/XMLDocumentParserLibxml2.cpp \
> +            xml/parser/XMLDocumentParserScope.cpp

Please reverse this,ie, contains(DEFINES, WTF_USE_LIBXML2=1) {} else {}
Comment 3 Allan Sandfeld Jensen 2012-04-27 06:30:31 PDT
Created attachment 139188 [details]
Patch

Patch for landing
Comment 4 WebKit Review Bot 2012-04-27 13:18:01 PDT
Comment on attachment 139188 [details]
Patch

Clearing flags on attachment: 139188

Committed r115482: <http://trac.webkit.org/changeset/115482>
Comment 5 WebKit Review Bot 2012-04-27 13:18:06 PDT
All reviewed patches have been landed.  Closing bug.