Bug 85042

Summary: Doesn't build with ENABLE_JIT=0
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: JavaScriptCoreAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, fpizlo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Allan Sandfeld Jensen 2012-04-27 02:36:35 PDT
Created attachment 139157 [details]
Patch

When building with JIT disabled JavaScriptCore fails to compile several files due to missing implementation of CallFrame::globalData.
Comment 1 Gavin Barraclough 2012-04-27 11:35:29 PDT
Comment on attachment 139157 [details]
Patch

Thanks for the fix!
Comment 2 WebKit Review Bot 2012-04-27 13:06:41 PDT
Comment on attachment 139157 [details]
Patch

Rejecting attachment 139157 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
webkit-commit-queue/Source/WebKit/chromium/webkit --revision 133673 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
48>At revision 133673.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/12559304
Comment 3 Allan Sandfeld Jensen 2012-05-04 05:34:53 PDT
Created attachment 140196 [details]
Patch
Comment 4 WebKit Review Bot 2012-05-04 06:56:22 PDT
Comment on attachment 140196 [details]
Patch

Clearing flags on attachment: 140196

Committed r116092: <http://trac.webkit.org/changeset/116092>
Comment 5 WebKit Review Bot 2012-05-04 06:56:27 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Allan Sandfeld Jensen 2012-08-10 08:26:05 PDT
Regressed again.
Comment 7 Allan Sandfeld Jensen 2012-08-10 08:27:56 PDT
Created attachment 157734 [details]
Patch
Comment 8 Eric Seidel (no email) 2012-08-12 04:29:20 PDT
Comment on attachment 157734 [details]
Patch

OK.
Comment 9 WebKit Review Bot 2012-08-12 04:47:49 PDT
Comment on attachment 157734 [details]
Patch

Clearing flags on attachment: 157734

Committed r125373: <http://trac.webkit.org/changeset/125373>
Comment 10 WebKit Review Bot 2012-08-12 04:47:54 PDT
All reviewed patches have been landed.  Closing bug.