| Summary: | Layout Test media/video-currentTime-set.html is still flaky | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||||||
| Component: | Tools / Tests | Assignee: | Dimitri Glazkov (Google) <dglazkov> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | eric.carlson, feature-media-reviews, fischman, scherkus, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Dimitri Glazkov (Google)
2012-04-26 13:53:10 PDT
(In reply to comment #0) > The following layout test is flaky on Win > > media/video-currentTime-set.html > > Probable cause: an extra message is added to the test: > > +No 'ended' event in 2 seconds FAIL > > I think the timeout we have there is superflous, since we already have timeout infrastructure in nwrt. We should just remove it. WDYT? Sounds like a great idea, rs=me :-) Created attachment 139076 [details]
Patch
Comment on attachment 139076 [details] Patch Clearing flags on attachment: 139076 Committed r115462: <http://trac.webkit.org/changeset/115462> All reviewed patches have been landed. Closing bug. Reopening to attach new patch. Created attachment 155684 [details]
Patch
Comment on attachment 155684 [details] Patch Rejecting attachment 155684 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: vn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/chromium/TestExpectations Hunk #1 FAILED at 3296. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/TestExpectations.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13391917 Created attachment 155715 [details]
Patch
Comment on attachment 155715 [details] Patch Clearing flags on attachment: 155715 Committed r124302: <http://trac.webkit.org/changeset/124302> All reviewed patches have been landed. Closing bug. |