Bug 85003

Summary: Layout Test media/video-currentTime-set.html is still flaky
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: Tools / TestsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, fischman, scherkus, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Dimitri Glazkov (Google)
Reported 2012-04-26 13:53:10 PDT
The following layout test is flaky on Win media/video-currentTime-set.html Probable cause: an extra message is added to the test: +No 'ended' event in 2 seconds FAIL I think the timeout we have there is superflous, since we already have timeout infrastructure in nwrt. We should just remove it. WDYT?
Attachments
Patch (1.39 KB, patch)
2012-04-26 14:51 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Patch (1.42 KB, patch)
2012-07-31 17:21 PDT, Ami Fischman 		no flags
DetailsFormatted DiffDiff
Patch (1.36 KB, patch)
2012-07-31 21:03 PDT, Ami Fischman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2012-04-26 14:43:06 PDT
(In reply to comment #0) > The following layout test is flaky on Win > > media/video-currentTime-set.html > > Probable cause: an extra message is added to the test: > > +No 'ended' event in 2 seconds FAIL > > I think the timeout we have there is superflous, since we already have timeout infrastructure in nwrt. We should just remove it. WDYT? Sounds like a great idea, rs=me :-)
Dimitri Glazkov (Google)
Comment 2 2012-04-26 14:51:47 PDT
Created attachment 139076 [details] Patch
WebKit Review Bot
Comment 3 2012-04-27 11:54:24 PDT
Comment on attachment 139076 [details] Patch Clearing flags on attachment: 139076 Committed r115462: <http://trac.webkit.org/changeset/115462>
WebKit Review Bot
Comment 4 2012-04-27 11:54:29 PDT
All reviewed patches have been landed. Closing bug.
Ami Fischman
Comment 5 2012-07-31 17:21:10 PDT
Reopening to attach new patch.
Ami Fischman
Comment 6 2012-07-31 17:21:13 PDT
Created attachment 155684 [details] Patch
WebKit Review Bot
Comment 7 2012-07-31 19:52:19 PDT
Comment on attachment 155684 [details] Patch Rejecting attachment 155684 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: vn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/chromium/TestExpectations Hunk #1 FAILED at 3296. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/TestExpectations.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13391917
Ami Fischman
Comment 8 2012-07-31 21:03:56 PDT
Created attachment 155715 [details] Patch
WebKit Review Bot
Comment 9 2012-07-31 22:17:44 PDT
Comment on attachment 155715 [details] Patch Clearing flags on attachment: 155715 Committed r124302: <http://trac.webkit.org/changeset/124302>
WebKit Review Bot
Comment 10 2012-07-31 22:17:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.