Summary: | Infinite backgroundClipRect should not be scrolled. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shawn Singh <shawnsingh> | ||||||
Component: | Layout and Rendering | Assignee: | Shawn Singh <shawnsingh> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | enne, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Shawn Singh
2012-04-26 11:37:00 PDT
Created attachment 139083 [details]
Patch
(In reply to comment #1) > Created an attachment (id=139083) [details] > Patch - includes new layout test - tested on all unit tests and layout tests, no obvious regressions Comment on attachment 139083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139083&action=review Nice test! A few small nits: > Source/WebCore/rendering/RenderLayer.cpp:3911 > + if (parentRects.fixed() && rootLayer->renderer() == view && !(backgroundClipRect == PaintInfo::infiniteRect())) !(x == y) => x != y If ClipRect somehow doesn't support !=, then maybe it should. > LayoutTests/compositing/iframes/resources/fixed-position-transformed-subframe.html:1 > +<html> <!DOCTYPE html> at the top, since this isn't about quirks mode. > LayoutTests/compositing/iframes/resources/fixed-position-transformed-subframe.html:33 > + if (window.internals) > + window.internals.settings.setMockScrollbarsEnabled(true); (Aren't mock scrollbars always on in compositing/ for Chromium and Safari?) > LayoutTests/compositing/iframes/resources/fixed-position-transformed-subframe.html:36 > + layoutTestController.waitUntilDone(); (I'm pretty sure you don't need to do waitUntilDone/notifyDone if you do everything in the onload handler.) > LayoutTests/compositing/iframes/scroll-fixed-transformed-element.html:1 > +<html> Same here. Created attachment 139104 [details]
Addressed reviewers comments
Comment on attachment 139104 [details]
Addressed reviewers comments
Nice, thanks! R=me.
Comment on attachment 139104 [details]
Addressed reviewers comments
Thanks for reviewing, as always =)
Comment on attachment 139104 [details] Addressed reviewers comments Clearing flags on attachment: 139104 Committed r115471: <http://trac.webkit.org/changeset/115471> All reviewed patches have been landed. Closing bug. |