Summary: | [GTK] Google tests that time out are leaked | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | pnormand | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2012-04-26 10:11:18 PDT
I've noticed that we are also leaking the Xvfb process for exactly the same reason, and I'm afraid the same happens with any other processes spawned by run-gtk-test, so I think option a) is the best one in the end. Created attachment 140507 [details]
Patch
This patch moves run-gtk-test to Tools/gtk directory renamed as run-api-tests. Tools/Scripts/run-gtk-test is a simple wrapper that checks whether jhbuild is available or not, so that it runs the whole script with jhbuild if present (instead of running jhbuild for every subprocess of the script). In case of using jhbuild, it uses the jhbuild-wrapper directly instead of run-with-jhbuild to avoid another unnecessary layer.
run-api-tests has been simplified a lot, using common.py to get top_level and build paths, and removing the _create_process helper used to run jhbuild.
This change should be transparent for users of run-gtk-tests, so we don't need any change in the bots.
Comment on attachment 140507 [details]
Patch
Looks good, thanks!
Committed r116410: <http://trac.webkit.org/changeset/116410> (In reply to comment #4) > Committed r116410: <http://trac.webkit.org/changeset/116410> Since this patch landed the API tests fail every 2 builds (so, green alternates with red API tests). Traceback: Traceback (most recent call last): File "./Tools/gtk/run-api-tests", line 353, in <module> sys.exit(TestRunner(options, args).run_tests()) File "./Tools/gtk/run-api-tests", line 291, in run_tests if not self._setup_testing_environment(): File "./Tools/gtk/run-api-tests", line 177, in _setup_testing_environment if not self._start_accessibility_daemons(): File "./Tools/gtk/run-api-tests", line 131, in _start_accessibility_daemons spi_bus_launcher_path = self._lookup_atspi2_binary('at-spi-bus-launcher') File "./Tools/gtk/run-api-tests", line 124, in _lookup_atspi2_binary filepath = os.path.join(exec_prefix, path, filename) File "/usr/lib/python2.6/posixpath.py", line 67, in join elif path == '' or path.endswith('/'): AttributeError: 'NoneType' object has no attribute 'endswith' Actually it failed all the times, I already fixed it in http://trac.webkit.org/changeset/116412 (In reply to comment #6) > Actually it failed all the times, I already fixed it in http://trac.webkit.org/changeset/116412 There is still something wrong going on in the Release bot. Can you check it please? |