Bug 84913

Summary: WebKit 1: Initialize deviceScaleFactor on creation of the WebView
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: Layout and RenderingAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, darin
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+
Patch that uses hostWindow instead darin: review+

Beth Dakin
Reported 2012-04-25 17:33:57 PDT
The change should be adopted for WebKit 1 as well: http://trac.webkit.org/changeset/107017 Without this, deviceScaleFactor will not be initialized until viewDidMoveToWindow, which is quite late for a background tab. <rdar://problem/11322716> Patch forthcoming.
Attachments
Patch (1.37 KB, patch)
2012-04-25 17:37 PDT, Beth Dakin 		darin: review+
DetailsFormatted DiffDiff
Patch that uses hostWindow instead (2.18 KB, patch)
2012-04-25 18:00 PDT, Beth Dakin 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2012-04-25 17:37:19 PDT
Created attachment 138907 [details] Patch
Darin Adler
Comment 2 2012-04-25 17:43:02 PDT
Comment on attachment 138907 [details] Patch OK
Darin Adler
Comment 3 2012-04-25 17:43:44 PDT
One difference with WebKit1 is that we have the “host window” concept. The host window should be set quite early for a background tab. I’d think we could change things so that a WebView that gets a host window could set its scale factor appropriately based on the host window.
Beth Dakin
Comment 4 2012-04-25 18:00:51 PDT
Created attachment 138913 [details] Patch that uses hostWindow instead
Darin Adler
Comment 5 2012-04-25 18:05:22 PDT
Comment on attachment 138913 [details] Patch that uses hostWindow instead This looks good. But for applications that don’t use a host window, I think we want the union of your previous patch and this one. I think we need both!
Beth Dakin
Comment 6 2012-04-25 18:11:06 PDT
Committed both: http://trac.webkit.org/changeset/115271
Note You need to log in before you can comment on or make changes to this bug.