Summary: | WebCore shouldn't call collectAllGarbage directly | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Hahnenberg <mhahnenberg> | ||||||
Component: | JavaScriptCore | Assignee: | Mark Hahnenberg <mhahnenberg> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, ggaren, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Mark Hahnenberg
2012-04-25 15:39:23 PDT
Created attachment 138891 [details]
Patch
With this patch, we do 133 GCs in a run of in-browser SunSpider running 20 iterations. We used to do 712 collections using this same testing setup. We also do 10 collections vs. 20 collections when loading TechCrunch. I should also mention that neither our wall clock time nor our benchmark score for in-browser SunSpider are affected by this patch. Comment on attachment 138891 [details] Patch Attachment 138891 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12520704 Created attachment 138899 [details]
Patch
Comment on attachment 138899 [details]
Patch
r=me
Comment on attachment 138899 [details] Patch Clearing flags on attachment: 138899 Committed r115288: <http://trac.webkit.org/changeset/115288> All reviewed patches have been landed. Closing bug. |