Bug 84875 – [Qt][WK2] Virtual keyboard is not showing when user clicks inside of <input> tag

• Component: WebKit Qt
• Status: RESOLVED WORKSFORME

[Alex Bravo]

This problem happens on both Linux (11.10 x64) and Harmattan/N9.

One simple solution is to either add ItemAcceptsInputMethod permanently in here (new line is marked with //AB).

From Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp:

QtWebPageEventHandler::QtWebPageEventHandler(WKPageRef pageRef, QQuickWebPage* qmlWebPage, QQuickWebView* qmlWebView)
    : m_webPageProxy(toImpl(pageRef))
    , m_interactionEngine(0)
    , m_panGestureRecognizer(this)
    , m_pinchGestureRecognizer(this)
    , m_tapGestureRecognizer(this)
    , m_webPage(qmlWebPage)
    , m_webView(qmlWebView)
    , m_previousClickButton(Qt::NoButton)
    , m_clickCount(0)
    , m_postponeTextInputStateChanged(false)
{
    connect(qApp->inputPanel(), SIGNAL(visibleChanged()), this, SLOT(inputPanelVisibleChanged()));
    m_webView->setFlag(QQuickItem::ItemAcceptsInputMethod, true);  //AB
}

Or alternatively add this flag only if editor content is editable:

void QtWebPageEventHandler::updateTextInputState()
{
    if (m_postponeTextInputStateChanged)
        return;

    const EditorState& editor = m_webPageProxy->editorState();

    if (!m_webView->hasFocus())
        return;

    // Ignore input method requests not due to a tap gesture.
    if (!editor.isContentEditable) {
        m_webView->setFlag(QQuickItem::ItemAcceptsInputMethod, false);  //AB
        setInputPanelVisible(false);
    }
}

void QtWebPageEventHandler::doneWithGestureEvent(const WebGestureEvent& event, bool wasEventHandled)
{
    if (event.type() != WebEvent::GestureSingleTap)
        return;

    m_postponeTextInputStateChanged = false;

    if (!wasEventHandled || !m_webView->hasFocus())
        return;

    const EditorState& editor = m_webPageProxy->editorState();
    bool newVisible = editor.isContentEditable;

    m_webView->setFlag(QQuickItem::ItemAcceptsInputMethod, newVisible);  //AB
}

Note: Once this issue with ItemAcceptsInputMethod is solved, another bug in focusEditableArea() (called from QtWebPageEventHandler::inputPanelVisibleChanged())
shows up. This bug prevents Virtual keyboard from showing when user clicks inside of <input> tag second time (after Edit area is zoomed in once.)
To temporary fix this problem and be able to use ZVirtual keyborad repeatedly, either zoom page manually or comment out two lines marked with //AB as shown below:

void QtWebPageEventHandler::inputPanelVisibleChanged()
{
    if (!m_interactionEngine)
        return;

    // We only respond to the input panel becoming visible.
    if (!m_webView->hasFocus() || !qApp->inputPanel()->visible())
        return;

    const EditorState& editor = m_webPageProxy->editorState();

//AB    if (editor.isContentEditable)
//AB        m_interactionEngine->focusEditableArea(QRectF(editor.cursorRect), QRectF(editor.editorRect));
}

[Jesus Sanchez-Palencia]

Alex, thanks for looking into this!

Do you plan to submit a patch for review following webkit guidelines?

[Alex Bravo]

(In reply to comment #1)
> Alex, thanks for looking into this!
> 
> Do you plan to submit a patch for review following webkit guidelines?

I wanted to get first the feedback on wheach of mentioned two ways of adding ItemAcceptsInputMethod is better before I do a patch.

[Kenneth Rohde Christiansen]

(In reply to comment #2)
> (In reply to comment #1)
> > Alex, thanks for looking into this!
> > 
> > Do you plan to submit a patch for review following webkit guidelines?
> 
> I wanted to get first the feedback on wheach of mentioned two ways of adding ItemAcceptsInputMethod is better before I do a patch.

Even if it is not for review, it would be so much easier to give comments if it was uploaded as a patch

[Alex Bravo]

Created attachment 138906 [details]
Patch

[Alex Bravo]

In the proccess of testing this patch I found out that the trunk works without this patch just fine - vkb is show and hidden.
Which means that more investigation is needed on my part to find out which of the other of my changes are needed for this patch.

[Lauro Moura Maranhao Neto]

How did you test it? I've just tested revision 115325 against the latest pinned Qt5 hash (From early April) and VKB is not shown. I tested using a release build with both Snowshoe[1] and Femto[2] on a PR1.2 N9.

[1] http://github.com/snowshoe/snowshoe/
[2] https://gitorious.org/femto/femto

[Alex Bravo]

(In reply to comment #6)
> How did you test it? 

I'm using MiniBrowser. I tested yesterday with trunk at  ebfce6a90080fe64aa07d009354ff4a975267782 on desktop.

[Noam Rosenthal]

(In reply to comment #7)
> (In reply to comment #6)
> > How did you test it? 
> 
> I'm using MiniBrowser. I tested yesterday with trunk at  ebfce6a90080fe64aa07d009354ff4a975267782 on desktop.

You mean, on desktop with maliit enabled :)

[Rafael Brandao]

(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > How did you test it? 
> > 
> > I'm using MiniBrowser. I tested yesterday with trunk at  ebfce6a90080fe64aa07d009354ff4a975267782 on desktop.
> 
> You mean, on desktop with maliit enabled :)

Did you run MiniBrowser in desktop mode or mobile?

[Alex Bravo]

> Did you run MiniBrowser in desktop mode or mobile?

I'm not using --desktop switch, which I guess makes it run in mobile mode?
What's the difference?

@No'am Yes, I malliit was installed. Abd Qt compiled with dbus.

[Alex Bravo]

I verified that vkb is shown and hidden in MiniBrowser using revision 115493.
There's still an issue with zooming in when the WebView is not the same size as the whole window, but that's a separate bug.

So I'm marking this bug as resolved.

[Noam Rosenthal]

Comment on attachment 138906 [details]
Patch

Clearing review flag.

[Manuel Kaufmann]

Created attachment 172077 [details]
Test case for type="text" and type="password" <input> tags

Test case

[Manuel Kaufmann]

Comment on attachment 172077 [details]
Test case for type="text" and type="password" <input> tags

I'm having a similar issue in Browse[1] (from the OLPC / Sugar Platform). It shows the Maliit virtual keyboard on <input type="text"> tags but it doesn't for <input type="password">.

I create a simple script as test case. It shows a webpage that has two <input> tags, one is type="text" which reveals the virtual keyboard and the other one is type="password" that doesn't reveal the VK. It's attached.

Any clue where I can take a look?

[1] http://git.sugarlabs.org/browse

[Manuel Kaufmann]

(In reply to comment #14)
> Any clue where I can take a look?

I found this bug that deals with this specific issue:

 * https://bugs.webkit.org/show_bug.cgi?id=34285