Bug 84853

Summary:

Share code used to animate discrete types between all animators

Product:

WebKit

Reporter:

Nikolas Zimmermann <zimmermann>

Component:

SVG

Assignee:

Nikolas Zimmermann <zimmermann>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
Patch	kling: review+

Nikolas Zimmermann

Reported 2012-04-25 06:05:02 PDT

Share code used to animate discrete types between all animators.

Attachments
Patch (24.51 KB, patch) 2012-04-25 06:08 PDT, Nikolas Zimmermann	kling: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Nikolas Zimmermann

Comment 1 2012-04-25 06:08:26 PDT

Andreas Kling

Comment 2 2012-04-26 00:44:57 PDT

Comment on attachment 138797 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138797&action=review Great cleanup, and you're adding a test. What's not to love? r=me > Source/WebCore/svg/SVGAnimateElement.h:52 > + virtual bool isAdditive() const; We should add OVERRIDE here.

Nikolas Zimmermann

Comment 3 2012-04-26 00:52:04 PDT

Note You need to log in before you can comment on or make changes to this bug.