Summary: | Share code used to animate discrete types between all animators | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> | ||||
Component: | SVG | Assignee: | Nikolas Zimmermann <zimmermann> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | zimmermann | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 41761 | ||||||
Attachments: |
|
Description
Nikolas Zimmermann
2012-04-25 06:05:02 PDT
Created attachment 138797 [details]
Patch
Comment on attachment 138797 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138797&action=review Great cleanup, and you're adding a test. What's not to love? r=me > Source/WebCore/svg/SVGAnimateElement.h:52 > + virtual bool isAdditive() const; We should add OVERRIDE here. Committed r115296: <http://trac.webkit.org/changeset/115296> |