Bug 84853

Summary: Share code used to animate discrete types between all animators
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Severity: Normal CC: zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 41761    
Description Flags
Patch kling: review+

Description Nikolas Zimmermann 2012-04-25 06:05:02 PDT
Share code used to animate discrete types between all animators.
Comment 1 Nikolas Zimmermann 2012-04-25 06:08:26 PDT
Created attachment 138797 [details]
Comment 2 Andreas Kling 2012-04-26 00:44:57 PDT
Comment on attachment 138797 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=138797&action=review

Great cleanup, and you're adding a test. What's not to love? r=me

> Source/WebCore/svg/SVGAnimateElement.h:52
> +    virtual bool isAdditive() const;

We should add OVERRIDE here.
Comment 3 Nikolas Zimmermann 2012-04-26 00:52:04 PDT
Committed r115296: <http://trac.webkit.org/changeset/115296>