Bug 84850

Summary: MediaStream API: Changing webkitGetUserMedia to take an object instead of a string
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebCore Misc.Assignee: Tommy Widenflycht <tommyw>
Severity: Normal CC: abarth, dglazkov, eric.carlson, feature-media-reviews, fishd, jamesr, ojan, s.choi, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56459    
Description Flags
Archive of layout-test-results from ec2-cr-linux-03
Patch none

Description Tommy Widenflycht 2012-04-25 05:28:48 PDT
The standard changed a while back to use an object as a dictionary but since JSC didn't support the Dictionary class until just recently we have not updated the API until now.
Comment 1 Tommy Widenflycht 2012-04-25 05:36:05 PDT
Created attachment 138790 [details]
Comment 2 WebKit Review Bot 2012-04-25 05:39:12 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 WebKit Review Bot 2012-04-25 12:40:09 PDT
Comment on attachment 138790 [details]

Attachment 138790 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12524804

New failing tests:
Comment 4 WebKit Review Bot 2012-04-25 12:40:15 PDT
Created attachment 138858 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 5 Tommy Widenflycht 2012-04-26 02:29:03 PDT
Created attachment 138959 [details]
Comment 6 WebKit Review Bot 2012-05-02 03:31:12 PDT
Comment on attachment 138959 [details]

Clearing flags on attachment: 138959

Committed r115810: <http://trac.webkit.org/changeset/115810>
Comment 7 WebKit Review Bot 2012-05-02 03:31:25 PDT
All reviewed patches have been landed.  Closing bug.