Bug 84839

Summary:

[EFL] [DRT] Add baselines for execCommand tests which are missing expected results

Product:

WebKit

Reporter:

Sudarsana Nagineni (babu) <naginenis>

Component:

WebKit EFL

Assignee:

Sudarsana Nagineni (babu) <naginenis>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

g.czajkowski, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
patch	none
patch	none
patch	none

Sudarsana Nagineni (babu)

Reported 2012-04-25 04:03:13 PDT

The following tests related to execCommand needs png and txt baselines to unksip. editing/execCommand/4580583-1.html = MISSING editing/execCommand/4580583-2.html = MISSING editing/execCommand/4641880-1.html = MISSING editing/execCommand/4641880-2.html = MISSING editing/execCommand/4747450.html = MISSING editing/execCommand/4916402.html = MISSING editing/execCommand/4916541.html = MISSING editing/execCommand/4924441.html = MISSING editing/execCommand/5080333-1.html = MISSING editing/execCommand/5080333-2.html = MISSING editing/execCommand/5136770.html = MISSING editing/execCommand/5138441.html = MISSING editing/execCommand/5142012-1.html = MISSING editing/execCommand/5142012-2.html = MISSING editing/execCommand/5190926.html = MISSING editing/execCommand/5481523.html = MISSING editing/execCommand/5482023.html = MISSING editing/execCommand/5569741.html = MISSING editing/execCommand/create-list-with-hr.html = MISSING editing/execCommand/find-after-replace.html = MISSING editing/execCommand/findString-2.html = MISSING editing/execCommand/findString.html = MISSING editing/execCommand/indent-empty-root.html = MISSING editing/execCommand/indent-list-item.html = MISSING editing/execCommand/indent-selection.html = MISSING editing/execCommand/insert-list-and-stitch.html = MISSING editing/execCommand/insertHorizontalRule.html = MISSING editing/execCommand/insertImage.html = MISSING editing/execCommand/nsresponder-indent.html = MISSING editing/execCommand/nsresponder-outdent.html = MISSING editing/execCommand/outdent-blockquote-test1.html = MISSING editing/execCommand/outdent-blockquote-test2.html = MISSING editing/execCommand/outdent-blockquote-test3.html = MISSING editing/execCommand/outdent-blockquote-test4.html = MISSING editing/execCommand/paste-1.html = MISSING editing/execCommand/paste-2.html = MISSING editing/execCommand/print.html = MISSING editing/execCommand/remove-list-from-range-selection.html = MISSING editing/execCommand/remove-list-item-1.html = MISSING editing/execCommand/selectAll.html = MISSING

Attachments
Patch (638.80 KB, patch) 2012-05-23 04:26 PDT, Sudarsana Nagineni (babu)	no flags	Details Formatted Diff Diff
patch (93.31 KB, patch) 2012-05-24 05:46 PDT, Sudarsana Nagineni (babu)	no flags	Details Formatted Diff Diff
patch (638.78 KB, patch) 2012-05-24 05:49 PDT, Sudarsana Nagineni (babu)	no flags	Details Formatted Diff Diff
patch (638.87 KB, patch) 2012-05-24 06:43 PDT, Sudarsana Nagineni (babu)	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Sudarsana Nagineni (babu)

Comment 1 2012-05-23 04:26:29 PDT

Created attachment 143529 [details] Patch Add baselines for execCommand tests.

Grzegorz Czajkowski

Comment 2 2012-05-23 06:59:43 PDT

I removed tests(editing/style) in http://trac.webkit.org/changeset/118172 that are not related with this bug. We cannot deliver results for them because of missing copy and paste implementation. Please rebase the patch.

Sudarsana Nagineni (babu)

Comment 3 2012-05-24 05:46:49 PDT

Created attachment 143802 [details] patch rebased

Sudarsana Nagineni (babu)

Comment 4 2012-05-24 05:49:55 PDT

Created attachment 143803 [details] patch forgot to include binary diff in the previous patch

Sudarsana Nagineni (babu)

Comment 5 2012-05-24 06:43:41 PDT

Created attachment 143819 [details] patch Updated changelog entry. Thanks Grzegorz for notifying me.

WebKit Review Bot

Comment 6 2012-05-24 07:42:57 PDT

Comment on attachment 143819 [details] patch Clearing flags on attachment: 143819 Committed r118370: <http://trac.webkit.org/changeset/118370>

WebKit Review Bot

Comment 7 2012-05-24 07:43:02 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.