Bug 84805

Summary: [chromium] Hold video provider lock from willDraw to didDraw
Product: WebKit Reporter: Adrienne Walker <enne>
Component: WebCore Misc.Assignee: Adrienne Walker <enne>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, enne, eric.carlson, feature-media-reviews, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 84807, 84812    
Bug Blocks:    
Attachments:
Description Flags
Patch jamesr: review+

Adrienne Walker
Reported 2012-04-24 17:02:16 PDT
It's possible for the video provider and frame to go away after willDraw, but before the frame gets uploaded into textures. Since the frame is a raw pointer (that the provider is responsible for), this could cause a bad memory access. Unfortunately, this depends on some other fixes to make sure that we don't ever call willDraw a second time without calling didDraw (which will deadlock on aquiring the exact same lock).
Attachments
Patch (4.01 KB, patch)
2012-04-24 18:21 PDT, Adrienne Walker 		jamesr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrienne Walker
Comment 1 2012-04-24 18:21:31 PDT
Created attachment 138712 [details] Patch
James Robinson
Comment 2 2012-04-25 15:53:02 PDT
Comment on attachment 138712 [details] Patch R=me
Adrienne Walker
Comment 3 2012-04-25 19:05:59 PDT
Committed r115281: <http://trac.webkit.org/changeset/115281>
Note You need to log in before you can comment on or make changes to this bug.