Bug 84734

Summary:

Rename CSSStyleSelector class to StyleResolver.

Product:

WebKit

Reporter:

Alexis Menard (darktears) <menard>

Component:

CSS

Assignee:

Alexis Menard (darktears) <menard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, feature-media-reviews, kling, koivisto, macpherson, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

42764

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Alexis Menard (darktears) 2012-04-24 09:34:52 PDT

Rename CSSStyleSelector class to StyleResolver.

Comment 1 Alexis Menard (darktears) 2012-04-24 09:36:24 PDT

Created attachment 138580 [details]
Patch

Comment 2 WebKit Review Bot 2012-04-24 09:43:13 PDT

Attachment 138580 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/CSSStyleSelector.cpp:1503:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSelector.cpp:1574:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSelector.cpp:1636:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSelector.cpp:1756:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSelector.cpp:1803:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSelector.cpp:2159:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSelector.cpp:2164:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSelector.cpp:4236:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSelector.cpp:4252:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSelector.cpp:4260:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSelector.cpp:4270:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSelector.cpp:5452:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSelector.cpp:5529:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSelector.cpp:5749:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSelector.h:122:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/rendering/style/RenderStyle.h:130:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 16 in 73 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Alexis Menard (darktears) 2012-04-24 09:45:10 PDT

(In reply to comment #2)
> Attachment 138580 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
> Source/WebCore/css/CSSStyleSelector.cpp:1503:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
> Source/WebCore/css/CSSStyleSelector.cpp:1574:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
> Source/WebCore/css/CSSStyleSelector.cpp:1636:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
> Source/WebCore/css/CSSStyleSelector.cpp:1756:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
> Source/WebCore/css/CSSStyleSelector.cpp:1803:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
> Source/WebCore/css/CSSStyleSelector.cpp:2159:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
> Source/WebCore/css/CSSStyleSelector.cpp:2164:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
> Source/WebCore/css/CSSStyleSelector.cpp:4236:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
> Source/WebCore/css/CSSStyleSelector.cpp:4252:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
> Source/WebCore/css/CSSStyleSelector.cpp:4260:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
> Source/WebCore/css/CSSStyleSelector.cpp:4270:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
> Source/WebCore/css/CSSStyleSelector.cpp:5452:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
> Source/WebCore/css/CSSStyleSelector.cpp:5529:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
> Source/WebCore/css/CSSStyleSelector.cpp:5749:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
> Source/WebCore/css/CSSStyleSelector.h:122:  More than one command on the same line  [whitespace/newline] [4]
> Source/WebCore/rendering/style/RenderStyle.h:130:  More than one command on the same line  [whitespace/newline] [4]
> Total errors found: 16 in 73 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

I think we can ignore that.

Comment 4 Andreas Kling 2012-04-24 12:34:59 PDT

Comment on attachment 138580 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138580&action=review

rs=me, now don't go breaking my heart!

>> Source/WebCore/css/CSSStyleSelector.h:122
>> +    WTF_MAKE_NONCOPYABLE(StyleResolver);WTF_MAKE_FAST_ALLOCATED;
> 
> More than one command on the same line  [whitespace/newline] [4]

At least put a space after the ;

Comment 5 Alexis Menard (darktears) 2012-04-24 12:41:46 PDT

Created attachment 138623 [details]
Patch for landing

Comment 6 Alexis Menard (darktears) 2012-04-24 12:46:57 PDT

Committed r115097: <http://trac.webkit.org/changeset/115097>