| Summary: | [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dominik Röttsches (drott) <d-r> | ||||||||||||
| Component: | Tools / Tests | Assignee: | Dominik Röttsches (drott) <d-r> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | dpranke, gustavo, rakuco, rwlbuis, tmpsantos, webkit.review.bot | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | 95320 | ||||||||||||||
| Bug Blocks: | 95237 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Dominik Röttsches (drott)
2012-04-24 04:33:36 PDT
Created attachment 138536 [details]
CMake warnings
Do you have any idea on this Raphael? I looked around and found this post about using CMAKE_PREFIX_PATH and I remember you had a bug filed for this, is that right? Found it - it was bug 81491 - but apparently that didn't fully resolve the issue. I don't get these warnings here, but had libcairo.so and libgio.so depending on wrong versions of a few libraries. The problem in libcairo was solved by rebuilding it (I haven't rebuilt glib to see if its problems go away yet). From the CMakeCache.txt you posted to me earlier today, CMake is finding the right headers for cairo but the wrong library -- can you double check libcairo.so is properly installed in your Root/lib directory and, if it is, remove your CMakeCache.txt and try again? http://build.webkit.org/builders/EFL%20Linux%20Debug/builds/671/steps/compile-webkit/logs/stdio is a completely fresh build, Dependencies and Debug folders deleted - that means, there wasn't an old CMakeCache.txt there either. Issue persists. Created attachment 147045 [details]
Patch
Created attachment 147048 [details]
Patch v2, prefix needed on 64bit only.
Created attachment 147050 [details]
Patch v3, keep prefix path definition on 32bit.
(In reply to comment #8) > Created an attachment (id=147050) [details] > Patch v3, keep prefix path definition on 32bit. This was successfully tested on 64bit and 32bit machines. Kindly requesting cq+. Comment on attachment 147050 [details] Patch v3, keep prefix path definition on 32bit. Clearing flags on attachment: 147050 Committed r120113: <http://trac.webkit.org/changeset/120113> All reviewed patches have been landed. Closing bug. Time to revisit this: the fix does not look OK, as CMake uses the value of $CMAKE_PREFIX_PATH as a root directory for FIND_PATH(), FIND_LIBRARY() and FIND_EXECUTABLE(). If it is set to /somewhere/lib64, it will not work as expected. This is causing problems with bug 95237. I've talked to Dominik on IRC, and we have agreed to roll this patch out for now to see if the warnings persist now that most Find modules have been rewritten. If they do, I'll try to fix them ASAP. Re-opened since this is blocked by 95320 Warnings are back after the rollout: http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug%20WK2/builds/2348/steps/compile-webkit/logs/stdio Showing that system fontconfig is used :-( Alright, so now we get a different warning according to <http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug%20WK2/builds/2348/steps/compile-webkit/logs/stdio> Which means my rewrites of the Find modules have worked in this regard :-) FindFontconfig.cmake itself is not in a very good shape, but should work. I'll send a patch here that should make its detection work fine, and hopefully fix the EWS errors in bug 95237 as well. Created attachment 161227 [details]
Patch
Committed r127003: <http://trac.webkit.org/changeset/127003> |