Bug 84636

Summary: Add createPath and TextMetrics baseline
Product: WebKit Reporter: Charles Pritchard <chuck>
Component: CanvasAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: abarth, krit, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
opaque CanvasPath and float baseline
none
Adds baseline attribute to TextMetrics object for Canvas2d
none
Attempts to add and compile CanvasPath object for Canvas2d createPath none

Charles Pritchard
Reported 2012-04-23 14:42:50 PDT
Created attachment 138429 [details] opaque CanvasPath and float baseline This patch is intended to add a basic "CanvasPath createPath()" method to Canvas 2d which returns an opaque CanvasPath object that can be used later through beginPath(CanvasPath); It also adds float TextMetrics baseline accessed through measureText(str).baseline.
Attachments
opaque CanvasPath and float baseline (15.17 KB, patch)
2012-04-23 14:42 PDT, Charles Pritchard 		no flags
DetailsFormatted DiffDiff
Adds baseline attribute to TextMetrics object for Canvas2d (2.71 KB, patch)
2012-07-10 19:02 PDT, Charles Pritchard 		no flags
DetailsFormatted DiffDiff
Attempts to add and compile CanvasPath object for Canvas2d createPath (16.32 KB, patch)
2012-07-10 19:04 PDT, Charles Pritchard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Charles Pritchard
Comment 1 2012-07-10 19:02:38 PDT
Created attachment 151576 [details] Adds baseline attribute to TextMetrics object for Canvas2d Separated the TextMetrics and CanvasPath patches
Charles Pritchard
Comment 2 2012-07-10 19:04:11 PDT
Created attachment 151577 [details] Attempts to add and compile CanvasPath object for Canvas2d createPath Still failing on missing symbol "__ZN7WebCore4toJSEPN3JSC9ExecStateEPNS_17JSDOMGlobalObjectEPNS_10CanvasPathE" seems to need generation somewhere.
WebKit Review Bot
Comment 3 2012-07-10 19:07:34 PDT
Attachment 151576 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/html/TextMetrics.h', u'Sour..." exit_code: 1 Source/WebCore/html/TextMetrics.idl:30: Line contains tab character. [whitespace/tab] [5] Source/WebCore/html/TextMetrics.idl:31: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dirk Schulze
Comment 4 2014-04-03 14:00:00 PDT
We have the Path2D object now.
Note You need to log in before you can comment on or make changes to this bug.