Bug 84610

Summary:

SVG feConvolveMatrix does not implement kernelUnitLength

Product:

WebKit

Reporter:

Stephen Chenney <schenney>

Component:

SVG

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

ahmad.saleem792, ap, bfulgham, krit, mmaxfield, rniwa, sabouhallawa, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
smiley.jpeg	none
test case	none

Stephen Chenney

Reported 2012-04-23 10:28:00 PDT

The code in FEConvolveMatrix::platformApply does not make any use of the kernelUnitLength property on the filter. Code search did turn up any usage anywhere. I conclude that we have not implemented it.

Attachments
smiley.jpeg (6.25 KB, image/jpeg) 2022-07-14 12:46 PDT, Said Abou-Hallawa	no flags	Details
test case (5.47 KB, text/html) 2022-07-14 12:48 PDT, Said Abou-Hallawa	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Dirk Schulze

Comment 1 2012-04-23 10:30:20 PDT

(In reply to comment #0) > The code in FEConvolveMatrix::platformApply does not make any use of the kernelUnitLength property on the filter. Code search did turn up any usage anywhere. I conclude that we have not implemented it. That is correct. I think the current spec is a bit vague on how it should work. At least it was not clear to me how we could implement at the time I worked on SVG filters.

Ahmad Saleem

Comment 2 2022-07-14 08:54:58 PDT

I can see now references to "kernelUnitLength": https://github.com/WebKit/WebKit/blob/717edcf5882531d38e55c9cd7929667af2b319a8/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp#L34 https://github.com/WebKit/WebKit/blob/717edcf5882531d38e55c9cd7929667af2b319a8/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.h#L41 Is it now implemented? If yes, can this bug be closed? Thanks!

Ryosuke Niwa

Comment 3 2022-07-14 11:57:36 PDT

Said? Is this now implemented?

Said Abou-Hallawa

Comment 4 2022-07-14 12:45:13 PDT

No it is not implemented. See FEConvolveMatrixSoftwareApplier::apply() and notice that m_effect.kernelUnitLength() is not used.

Said Abou-Hallawa

Comment 5 2022-07-14 12:46:19 PDT

Created attachment 460900 [details] smiley.jpeg

Said Abou-Hallawa

Comment 6 2022-07-14 12:48:21 PDT

Created attachment 460901 [details] test case Two different filters are applied to the two images. FireFox is the only browser that renders the second image correctly.

Note You need to log in before you can comment on or make changes to this bug.