Bug 8459

Summary: REGRESSION: Content lost during a delete/merge of whitespace:pre text
Product: WebKit Reporter: Justin Garcia <justin.garcia>
Component: HTML EditingAssignee: Justin Garcia <justin.garcia>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P1    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch hyatt: review+

Justin Garcia
Reported 2006-04-18 11:13:29 PDT
editing/deleting/merge-whitespace-pre.html shows this. It started failing after hyatt's changes, but he says that the prune() in moveParagraph is removing rendered content, so I need to work on this.
Attachments
patch (8.32 KB, patch)
2006-04-26 00:28 PDT, Justin Garcia 		hyatt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Justin Garcia
Comment 1 2006-04-26 00:28:11 PDT
Created attachment 7968 [details] patch
Darin Adler
Comment 2 2006-04-26 08:15:43 PDT
Comment on attachment 7968 [details] patch Why the check for canHaveChildren?
Justin Garcia
Comment 3 2006-04-26 12:55:56 PDT
> Why the check for canHaveChildren? If the node passed to prune is a rendered leaf, like some text or an image, it will be removed and its parent's pruned without the !renderer->canHaveChildren() check.
Justin Garcia
Comment 4 2006-04-26 13:00:36 PDT
"its parents pruned"
Dave Hyatt
Comment 5 2006-04-26 13:30:43 PDT
Comment on attachment 7968 [details] patch r=me
Justin Garcia
Comment 6 2006-04-27 03:27:41 PDT
fixed in r1669
Note You need to log in before you can comment on or make changes to this bug.