Summary: | Blackberry incorrectly only allows netscape plugins named jnext and flash | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Benjamin Meyer <ben> | ||||||
Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | tonikitoo, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | Other | ||||||||
Attachments: |
|
Description
Benjamin Meyer
2012-04-21 10:29:42 PDT
Created attachment 138245 [details]
patch
Attachment 138245 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Sou..." exit_code: 1
Source/WebKit/blackberry/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 138245 [details]
patch
Put the bug number in the changelog and commit message. Also, remove the typo in the changelog entry for 'implement ion' that should be 'implementation'
Created attachment 138247 [details]
patch
Comment on attachment 138247 [details] patch Clearing flags on attachment: 138247 Committed r114849: <http://trac.webkit.org/changeset/114849> All reviewed patches have been landed. Closing bug. |