Bug 84519

Summary: [chromium] Animations waiting for a synchronized start time should never be marked finished.
Product: WebKit Reporter: vollick
Component: WebKit Misc.Assignee: vollick
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, epenner, jamesr, nduca, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

vollick
Reported 2012-04-20 19:10:36 PDT
Currently, when a main-thread animation is waiting for its impl-thread counterpart to start animating, it still gets ticked and at each tick considers the normalized time (current time - start time) to be zero. That is, it pauses at the first keyframe. The problem is that if (current time - start time) > duration, then we consider the animation finished and remove it. This is invalid if the animation is waiting for a start time from the impl-thread: it hasn't really started at all. So in ::tickAnimations, we must not consider an animation finished if it is waiting for a synchronized start time.
Attachments
Patch (5.44 KB, patch)
2012-04-20 19:22 PDT, vollick 		no flags
DetailsFormatted DiffDiff
Patch (5.52 KB, patch)
2012-04-20 19:38 PDT, vollick 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
vollick
Comment 1 2012-04-20 19:22:47 PDT
Created attachment 138216 [details] Patch
Nat Duca
Comment 2 2012-04-20 19:26:42 PDT
Comment on attachment 138216 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138216&action=review Nice. Might tweak the phrasing but LGTM. > Source/WebKit/chromium/tests/CCLayerAnimationControllerTest.cpp:193 > +// Tests animations that are waiting for a synchronized start time do not finish. DoNotFinishIfTheyWaitLongerToStartThanTheirDuration?
vollick
Comment 3 2012-04-20 19:38:01 PDT
Created attachment 138217 [details] Patch (In reply to comment #2) > (From update of attachment 138216 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=138216&action=review > > Nice. Might tweak the phrasing but LGTM. > > > Source/WebKit/chromium/tests/CCLayerAnimationControllerTest.cpp:193 > > +// Tests animations that are waiting for a synchronized start time do not finish. > > DoNotFinishIfTheyWaitLongerToStartThanTheirDuration? Done. I think I may have broken some sort of record with this test name. :)
Eric Penner
Comment 4 2012-04-23 11:34:52 PDT
Confirmed this fixes the issue. Thanks!
James Robinson
Comment 5 2012-04-24 19:08:44 PDT
Comment on attachment 138217 [details] Patch r=me
WebKit Review Bot
Comment 6 2012-04-25 07:15:45 PDT
Comment on attachment 138217 [details] Patch Clearing flags on attachment: 138217 Committed r115202: <http://trac.webkit.org/changeset/115202>
WebKit Review Bot
Comment 7 2012-04-25 07:15:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.