Bug 84510

Summary:

Convert fast/tokenizer/missing-style-end-tag-1.html from a pixel test to text test

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

dbates

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Layout test	none

Daniel Bates

Reported 2012-04-20 16:26:14 PDT

It seems sufficient to make fast/tokenizer/missing-style-end-tag-1.html a text-only test.

Attachments
Layout test (4.24 KB, patch) 2012-04-20 16:27 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2012-04-20 16:27:57 PDT

Created attachment 138189 [details] Layout test

Ryosuke Niwa

Comment 2 2012-05-10 01:00:14 PDT

Comment on attachment 138189 [details] Layout test View in context: https://bugs.webkit.org/attachment.cgi?id=138189&action=review > LayoutTests/fast/tokenizer/missing-style-end-tag-1-expected.txt:1 > + It's not obvious to me what this test is trying to test after the conversion. > LayoutTests/fast/tokenizer/missing-style-end-tag-1.html:6 > +<script> > +if (window.layoutTestController) > + layoutTestController.dumpAsText(); > +</script> Please consider using dump-as-markup.js That way, it dumps the DOM structure, and you can use Markup.description() to add a test description.

Daniel Bates

Comment 3 2012-05-13 23:45:32 PDT

Comment on attachment 138189 [details] Layout test Clearing review and commit queue flags to look into writing this test using dump-as-markup.

Note You need to log in before you can comment on or make changes to this bug.